Repository navigation
Lift the Aqua bound in the test environment - #298
Merged
Merged
Conversation
Compat only. No package code changes. Aqua 0.8.18, released 2026-09-18, fixes the persistent_tasks bug commit 5c28167 bounded against: its release notes say test_persistent_tasks "no longer errors on a weak dependency that is also listed in [deps] but not installed", which is exactly the EnzymeCore-behind-KernelAbstractions case here. Aqua = "0.8" again, and the now-stale explanatory comment is removed with it. julia-branch-verifier confirmed: Aqua resolves to 0.8.18, KernelAbstractions stays at 0.9.42, persistent_tasks passes (1/1), and the whole aqua.jl testset is green (10/10). Co-Authored-By: Claude Sonnet 5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 80.87% 80.87%
=======================================
Files 80 80
Lines 3153 3153
=======================================
Hits 2550 2550
Misses 603 603 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aqua = "0.8.0 - 0.8.16"bound intest/Project.toml(from Bound Aqua below 0.8.17 in the test environment #288 / commit5c28167a) back to plainAqua = "0.8", and removes the now-stale explanatory comment.EnzymeCorebehindKernelAbstractions) no longer stopstest_persistent_tasks's manifest walk.Pre-PR verification
Checked and clean
Aqua.test_persistent_tasks(GeometricMachineLearning)passes with Aqua resolved to 0.8.18 and KernelAbstractions 0.9.42 — the same KernelAbstractions version present in the last green run and in the red one. Julia 1.13.0, fresh process,--check-bounds=auto.EnzymeCorestanza in its manifest, andBase.locate_packageforEnzymeCorereturnsnothing. Under 0.8.17 that value reacheserror("Unable to locate \EnzymeCore` …"); 0.8.18 filters[weakdeps]out of the manifest entry'sdeps` and skips an uninstalled weak dependency.test/aqua.jltestset is green — 10 passes, 8.2 s — run with the package setruntests.jlhas loaded by that point (Zygote,GeometricIntegrators,HDF5). This covers the six enabledtest_allchecks and theAqua.Piracy.hunt == 12gate.CHANGELOG.mdfor v0.8.18, and the 2026-09-18 release date matches.test/Project.tomlnow carries no comment at all. No reference to0.8.16/0.8.17remains anywhere outsideCHANGELOG.md.[deps]/[compat]are identical between 0.8.16 and 0.8.18, so lifting the bound moves no other package in the resolution.julia = "1.0", so theminCI job cannot be pushed back onto a broken version by a Julia-version constraint.Considered and declined: a floor of
Aqua = "0.8.18"would close the (CI-safe) risk of a stale localtest/Manifest.tomlstaying on 0.8.17. Declined to keep the bound consistent with the tree-wide convention (plain"0.8", as every other package's Aqua entry reads, and as SimpleSplines' equivalent unpin — JuliaDEC/SimpleSplines.jl#21 — also settled on).Not checked
Pkg.test()— outside the scope of the pre-PR gate.test/aqua.jlis the only test file that uses Aqua, the diff changes nosrc/and no other test file, and no other package moved in the resolution.docs/change and no Julia source changed.🤖 Generated with Claude Code