Repository navigation
Pin Aqua to 0.8.16 - #16
Merged
Merged
Conversation
Compat only. No package code changes. Aqua 0.8.17, released 2026-09-17, turns `persistent_tasks` red on every CI platform and Julia version. Its #394 writes the precompile wrapper's manifest from `Base.locate_package`, and the `manifest_entries` walk it added iterates each project's `deps` and `weakdeps`, raising when one cannot be located. An uninstalled weak dependency is the normal case -- here `ChainRulesCore` behind `AbstractFFTs`, reached through FFTW -- so the check fails on a healthy environment. `Aqua.test_all` stops at its first failing check, so this took the rest of `runtests.jl` with it: the suite appeared to run and had verified nothing after `aqua_tests.jl`. An exact bound, because 0.8.17 is the broken version and a range that excludes it has no other spelling. Lift it to "0.8" when the walk skips weak dependencies it cannot locate. Co-Authored-By: Claude Opus 5 <[email protected]>
1 task done
michakraus
added a commit
that referenced
this pull request
Sep 18, 2026
Compat only. No package code changes. Aqua 0.8.18, released 2026-09-18, fixes the persistent_tasks bug the pin in PR #16 worked around: its release notes say test_persistent_tasks "no longer errors on a weak dependency that is also listed in [deps] but not installed", which is exactly the ChainRulesCore-behind-AbstractFFTs case here. Project.toml already reads Aqua = "0.8" -- CompatHelper's PR #19 merged that change to main without a CHANGELOG entry. This closes that gap. Pkg.test() confirms: Aqua resolves to 0.8.18, persistent_tasks passes, and the full suite (65 968 tests) is green. Co-authored-by: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compat only. No package code changes, and nothing a caller sees changes.
What broke
Aqua v0.8.17, released 2026-09-17 at 16:46 UTC, turns thepersistent_taskscheck red on every CI platform and Julia version:Aqua#394 writes the precompile wrapper's manifest from
Base.locate_packageinstead ofPkg.develop, which is a good change. But themanifest_entrieswalk it added iteratesand calls
error("Unable to locate$name, a dependency of$(prj["name"])")whenlocate_packagereturns nothing. An uninstalled weak dependency is the normal case, not a fault.AbstractFFTsdeclaresChainRulesCoreas a weakdep, this package reachesAbstractFFTsthrough FFTW, andChainRulesCoreis not loaded in the test process — so the check fails on a perfectly healthy environment.Aqua.test_alladds no enclosing testset and stops at its first failing check, so the error took the rest ofruntests.jlwith it. A suite that looked like it had run had verified nothing afteraqua_tests.jl.Why an exact bound
0.8.17is the broken version and a range that excludes it has no other spelling:"0.8"and"~0.8.16"both admit it. Lift the bound back to"0.8"when the walk skips weak dependencies it cannot locate, and drop the pin with it. CompatHelper will propose bumps against this; decline them until upstream is fixed.Evidence that this is the whole cause
mainwas last green on 2026-09-15, before the Aqua release. On this branch, which changes nothing but[compat],Pkg.test()resolvesAqua v0.8.16and the full suite passes,aqua_tests.jlincluded.This also unblocks #15, whose every test job is red for this reason and for no other.
🤖 Generated with Claude Code