Skip to content

chore: establish MappedFair app foundation - #2

Draft
JaeTierce31 wants to merge 8 commits into
mainfrom
feat/mappedfair-foundation
Draft

JaeTierce31 wants to merge 8 commits into
mainfrom
feat/mappedfair-foundation

Conversation

@JaeTierce31

@JaeTierce31 JaeTierce31 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

Establishes the MappedFair app foundation and the first single-device offline venue and itinerary slice. PRs #3 and #4 have merged into this foundation branch; this PR remains a draft for review before main.

  • React + TypeScript + Vite workspace, Tailwind, documented feature/domain/application/infrastructure boundaries, and a proposed ADR-001/build plan.
  • Six manually selected factual venue names and addresses with provenance; browse/search, add/remove/reorder stops, notes, and IndexedDB persistence.
  • Service worker precaches the app shell and bundled venue sample for repeat offline visits. UI shows readiness, save feedback, storage-denied errors, source attribution, and independent-app wording.
  • CI runs lint, unit/integration tests, typecheck, build, and Chromium browser acceptance tests.

Verification on latest head

Commit cf069b15761d63ef7615173def92ef0125522da9: CI run 36164916653 passed, including both Chromium tests at http://127.0.0.1:4173 on Ubuntu 24.04. The tests cover service worker readiness, persisted order/note after offline reload, an offline edit after reconnect, denied IndexedDB access, and horizontal overflow at 390 px. Physical-device and keyboard usability are still to be checked.

Review and decision gates

  • Review the expanded PR diff, including the PR Add sourced offline venues and local itinerary MVP #3 save-status race fix and PR Verify offline itinerary reload in Chromium CI #4 browser assertions. An eligible independent review has not been submitted.
  • ADR-001 is proposed. The Minnesota State Fair map page and location-address page are authoritative references; no license was identified to redistribute map art, tiles, interactive map data, or a full directory. The six-place sample is an independently selected set of factual names and addresses, not a Fair-licensed dataset. Ratify its reuse boundary and assign seasonal revalidation before release.
  • Human keyboard/touch usability remains open. No rendered map, route claims, Firebase sync, BLE, AI, or payments are included.
  • Keep this PR draft until the remaining gates in J3S-35 are resolved and there is an explicit merge decision.

Refs #1

Verify offline itinerary reload in Chromium CI

Copy link
Copy Markdown
Member Author

Independent review handoff — expanded PR #2

Please review the full proposed foundation and offline itinerary diff on the latest head and submit a GitHub review. PRs #3 and #4 are included in this branch; PR #5 is still a separate, review-pending keyboard fix.

Review focus:

  1. The six factual venue records, per-record provenance and the ADR-001 boundary: no map artwork, tiles or full directory reuse; decide whether the proposed editorial sample and seasonal revalidation are acceptable.
  2. IndexedDB recovery, save-failure reporting, queued rapid edits and the PR Add sourced offline venues and local itinerary MVP #3 save-status fix.
  3. Service-worker offline behavior and latest-head CI run 36164916653, which passed two Chromium browser tests.
  4. UI semantics, keyboard/touch usability gaps and whether PR Keep keyboard focus in the itinerary after removing a stop #5 should be included before this PR is considered for main.

An independent review of PR #2 is still missing. This PR remains draft while ADR-001 ratification, human usability checks and the explicit merge decision in J3S-35 are outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant