Repository navigation
Add sourced offline venues and local itinerary MVP - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 846eed3c49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JaeTierce31
left a comment
There was a problem hiding this comment.
Self-review of the final stacked diff against #2: the six manually selected venue records have per-record provenance and rights basis; ADR-001 correctly leaves map artwork and bulk directory redistribution unlicensed and outside scope. Domain operations keep order unique and the IndexedDB adapter discards unknown/malformed stops. I found and fixed a rapid-edit save-status race before this review. Fresh local lint, 2 tests (including persisted stop order and note recovery), typecheck, build, and diff check pass; production build precaches 7 assets. Remaining verification: browser-based offline reload and mobile interaction after first online visit, plus seasonal revalidation of venue facts. This is a COMMENT review by the PR author, not independent approval. Please obtain a collaborator review before merging; the attempted request to J3SOVEREIGNTY was rejected by GitHub as not a repository collaborator.
Summary
Data source and licensing
The Minnesota State Fair's own map and location-address pages are authoritative references. No redistribution grant for the map artwork, tiles, or whole directory was identified. This PR includes only six independently selected factual names and addresses, no official imagery/branding, no downloaded maps or tile data. Expansion to maps or bulk imports is gated on permission or an explicit compatible license. Source: https://www.mnstatefair.org/guides/accessibility/locations ; source review: https://www.mnstatefair.org/maps and https://www.mnstatefair.org/about/logos-and-trademarks . The sample is a September 2026 observation, not a live or future-season availability claim.
Verification
npm run lint,npm test(2 passing, including IndexedDB order/note reload recovery),npm run typecheck,npm run build, andgit diff --checkpass locally.Dependency
Stacked on #2 (foundation branch). Review this diff against
feat/mappedfair-foundation; merge #2 first. No claim of independent approval.