Repository navigation
Keep keyboard focus in the itinerary after removing a stop - #5
JaeTierce31 wants to merge 1 commit into
Conversation
Independent review handoff — PR #5Please review commit Focus on:
CI run 36194824796 passed all three Chromium tests on this head. The result does not substitute for independent review or hands-on usability checks. After an eligible review and any fixes, PR #5 can merge into the foundation branch; then CI must be checked on PR #2's new head. |
Volunteer reviewer wanted — bounded React keyboard-focus changeWe are seeking a volunteer / no-cost independent human reviewer for this PR. There is no paid engagement or expectation of a favorable verdict. Scope: two files, 29 additions / 2 deletions at head
Existing review checklist · Passing CI receipt. To volunteer: reply here from your own GitHub account with relevant React/accessibility experience, any involvement in authoring this change, and the scope you can review. Maintainer will confirm reviewer eligibility. Please submit your own GitHub review tied to the reviewed commit, with findings and a judgment based on the evidence. No admin access or credentials are requested. Separate code inspection, automated tests, and human keyboard/touch tests in your report. For any hands-on checks, record browser/OS/device, steps and actual results; mark unperformed checks as untested. A code review alone will not close the human-usability gate. PR #2 is a larger, separately scoped review; volunteering here does not commit you to it. PR #5 remains unmerged pending eligible independent approval and resolution of findings. PR #2 stays draft/unmerged; ADR-001 and human checks remain open. |
Purpose
Address a keyboard interaction risk in the first offline itinerary slice. When someone removes the focused stop with Enter, move focus to the next available stop (or the previous one). When the plan becomes empty, focus the plan heading so the change has a clear context.
Change
Verification
Local lint, 2 unit/integration tests, typecheck, build, and diff check passed. CI run 36194824796 passed on commit
8d65bab7aae5c8c0969b4d382a0ddbc516f3b36f: all 3 Chromium acceptance tests passed, including the keyboard focus path. This is a focused keyboard behavior test; it is not a screenshot-based Product Design audit or a hands-on touch-device usability check.Review focus
Please check focus order and screen-reader expectations after removal, especially when the final stop is removed. This stacks on draft PR #2 and does not settle ADR-001 source rights or the independent review gate tracked by J3S-35.