[Payment due @Krishna2323] Describe a rule from New rule and fall back to an agent rule by yuwenmemon · Pull Request #103810 · Expensify/App

yuwenmemon · 2026-10-12T19:12:55Z

@puneetlath please review
cc @Krishna2323 @JmillsExpensify

Explanation of Change

Here's the plan: Admins describe a rule once, and we build a standard rule or, failing that, draft an agent rule. New rule shows the four rule templates, then a box to describe the rule. A rule answer opens that editor seeded on top, so Back returns to the description. unsupported and multipleRules open the agent rule page on the Write tab with the description prefilled and a banner explaining agent rules. Nothing saves before Create.

This sits behind the describeRule beta. Without the beta, New rule keeps "Describe agent rule". Needs product sign-off. On HOLD for App#104055, which this builds on for the category tax rate editor.

The Flag for review, Require fields and Spend editors now keep a seeded draft. With the beta, New rule has no agent option, so the Agents tab gets an Add agent rule row. The option descriptions are shorter for everyone.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/683436
PROPOSAL: N/A

Tests

Precondition: Enable the describeRule beta on the test account.

As a workspace admin on a Control workspace, open Rules > New rule.
Verify "Start with a template" lists the four rule types, and "Or just describe it below" shows a text box with Next at the bottom.

New rule with the templates and the describe section

3. Click into the box and out again, and verify no error shows. Tap Next with the box empty, and verify "Select a template or describe a rule to continue" shows above Next.

Describe "Flag meals expenses over $500 for review" and tap Next.
Verify the Flag for review editor opens prefilled, and Back returns to New rule with the description kept.

6. Describe "Block gift cards and require receipts over $50" and tap Next. 7. Verify the agent rule page opens on the Write tab, with the description prefilled and the banner shown.

8. Tap Back, then Discard changes, and verify you return to New rule without saving anything. 9. Describe "dsfsdfsdf" and verify the inline error appears.

10. Open Flag for review from New rule, tap Describe, and verify the editor still uses the Describe modal. 11. On a workspace that has an agent rule, open the Agents tab and verify Add agent rule shows under the list.

Add agent rule row under the Agents tab list

12. Tap Add agent rule and verify the agent rule page opens on the Suggested tab. 13. Open Categories, open a category, and tap Create new rule. Verify New rule lists the rule types without the describe section. 14. Turn the beta off with `Onyx.merge('betaOverrides', {describeRule: false})` in the console. Verify New rule lists the four rule types and Describe agent rule, without the describe section.

Verify that no errors appear in the JS console

Offline tests

Go offline on New rule and describe a rule.
Verify Next stays disabled and nothing navigates.

QA Steps

Precondition: Enable the describeRule beta on the test account.

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-10-12T19:18:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`33.63% <100.00%> (+0.30%)`	⬆️
src/libs/CategoryTaxRulesUtils.ts	`90.76% <100.00%> (+3.88%)`	⬆️
src/libs/ExpenseDefaultRuleUtils.ts	`97.95% <100.00%> (+0.02%)`	⬆️
src/libs/actions/Policy/Rules.ts	`78.03% <100.00%> (+0.33%)`	⬆️
...es/workspace/rules/AgentRules/AddAgentRulePage.tsx	`90.14% <100.00%> (+90.14%)`	⬆️
src/pages/workspace/rules/RulesNewPage.tsx	`82.14% <100.00%> (+82.14%)`	⬆️
src/pages/workspace/rules/tabs/RulesAgentsTab.tsx	`64.58% <100.00%> (+64.58%)`	⬆️
src/styles/index.ts	`66.22% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
src/pages/workspace/rules/DescribeRuleModal.tsx	`95.65% <85.71%> (+8.69%)`	⬆️
... and 8 more
... and 9 files with indirect coverage changes

melvin-bot · 2026-10-13T23:14:58Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-13T23:14:59Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T23:28:44.999056Z	`74eb5c7`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74eb5c7aaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-13T23:28:42Z

+        if (!policy?.areCategoriesEnabled || policyCategories) {
+            return;
+        }
+        openPolicyCategoriesPage(policyID);


Wait for categories before applying the generated rule

When the categories collection is absent, openPolicyCategoriesPage() only starts an asynchronous request while the describe modal remains usable. If GenerateRule responds before that request—or the categories request fails—DescribeRuleModal calls withPolicyCategory() with policyCategories still undefined, which permanently removes a generated category before opening the flag-for-review, require-fields, or merchant editor. On a cold cache this can therefore turn a valid category-based description into an incomplete draft; defer handling/submission until categories have loaded rather than merely initiating the fetch.

Useful? React with 👍 / 👎.

(Yuwen's Agent) Thanks — real race, but I think the current design handles it acceptably and the proposed deferral would add scope I'd want to confirm first.

The page already prefetches categories on focus (useFocusEffect → fetchPolicyCategories) and on reconnect (useNetwork), specifically so the collection is present before an answer arrives (see the comment at RulesNewPage.tsx:98-99).

generateRule only fires on form submit, which is seconds after focus, while the category read is a plain API read started at focus. So the read resolves well before the LLM round-trip returns in the normal case.

When withPolicyCategory drops the category, seedDraftAndNavigate still opens the editor with a reviewable draft. The admin sees the empty category and picks it before saving — no silent incomplete rule is persisted.

Gating submission on a loaded collection adds a loading/recovery path (product behavior), so I'll leave it as a trade-off for now rather than expand scope here.

yuwenmemon · 2026-10-14T07:09:30Z

(Yuwen's Agent) Thanks 🦜 — applied all 10 locale refinements in 6982ac1. The German fixes also align the du→Sie formality with Expensify's formal-address convention.

yuwenmemon · 2026-10-14T19:28:20Z

Reassigning to @Krishna2323 as per: https://expensify.slack.com/archives/C07HPDRELLD/p1792005989912279?thread_ts=1791798357.691669&cid=C07HPDRELLD

…rule

Krishna2323 · 2026-10-20T22:39:18Z

I'm testing the latest changes on native devices. I'll probably finish before the CI checks are done.

Krishna2323

LGTM!

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

MacOS: Chrome / Safari

web_chrome.mp4

melvin-bot · 2026-10-20T22:45:33Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-10-20T23:39:26Z

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-20T23:44:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103810.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc54f60-f8df561-c33da868d6f492e8b21d9adeda665a1a939e4c0d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc54f60-f8df561-2da73a2ed1b3fba7d1c2f595449b33acdcc0806d/index.html

Web 🕸️
https://103810.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-20T23:45:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-21T20:07:58Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T20:12:11Z

No help site update needed. The describe-a-rule flow is behind the describeRule beta. The changes everyone sees are shorter option descriptions on New rule, where the option names stay the same, and an extra Add agent rule row on the Agents tab. Neither change makes a sentence in Workspace Rules wrong.

view run

mitarachim · 2026-10-21T20:54:44Z

Deploy Blocker #104648 was identified to be related to this PR.

jponikarchuk · 2026-10-22T07:33:37Z

This PR failing because of the issue #104688
This issue is reproducible in: Web, Android app

OSBotify · 2026-10-22T19:22:05Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-22T19:27:01Z

A help site update is needed. I opened Docs updates for E/A#103810 Update New rule option descriptions in Workspace Rules.

This PR shortened three New rule option descriptions for all users. The Workspace Rules article still quoted the old text:

Flag for review – Notify approvers when expenses exceed category limits.

Set field requirements – Require specific expense fields or waive requiring them.

Apply expense defaults – Update fields without the submitter doing anything.

The docs PR changes only those three bullets to match the new UI copy. I didn't document the parts behind the describeRule beta, such as the describe section and the removal of Describe agent rule.

@yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run

OSBotify · 2026-10-23T16:53:14Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

melvin-bot · 2026-10-23T16:59:05Z

🤖 Payment issue created: #104872

melvin-bot Bot assigned yuwenmemon Oct 12, 2026

This comment has been minimized.

Sign in to view

yuwenmemon marked this pull request as ready for review October 13, 2026 23:14

yuwenmemon requested review from a team as code owners October 13, 2026 23:14

melvin-bot Bot requested review from dmkt9 and removed request for a team October 13, 2026 23:14

melvin-bot Bot requested a review from garrettmknight October 13, 2026 23:14

melvin-bot Bot removed the request for review from a team October 13, 2026 23:14

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

yuwenmemon added this pull request to stack #103951 October 13, 2026 23:39

yuwenmemon force-pushed the yuwen-683436-describeRuleAgentFallback branch 2 times, most recently from 496fd34 to dbcbc6a Compare October 13, 2026 23:54

This comment has been minimized.

Sign in to view

yuwenmemon requested a review from a team as a code owner October 14, 2026 06:47

This comment has been minimized.

Sign in to view

yuwenmemon mentioned this pull request Oct 14, 2026

[No QA]Document describing a rule on New rule #103852

Open

38 tasks

yuwenmemon added a commit that referenced this pull request Oct 14, 2026

chore(rules): merge the Agents tab add row from #103810

3113c5c

yuwenmemon added a commit that referenced this pull request Oct 14, 2026

chore(rules): merge the add agent rule row spacing from #103810

67677b7

yuwenmemon requested review from Krishna2323 and removed request for dmkt9 October 14, 2026 19:28

JmillsExpensify self-requested a review October 14, 2026 20:22

yuwenmemon added 2 commits October 14, 2026 13:38

feat(rules): describe a rule from New rule and fall back to an agent …

771f73a

…rule

test(rules): adapt describe-rule tests to main's modal and editors

8b1b913

chore(rules): merge main with the final App#104055 describe fixes

3534e9e

yuwenmemon added a commit that referenced this pull request Oct 20, 2026

chore(rules): merge main and the final App#104055 fixes from #103810

a599747

JS00001 previously approved these changes Oct 20, 2026

View reviewed changes

chore(rules): merge main into the describe rule branch

b661277

yuwenmemon dismissed JS00001’s stale review via b661277 October 20, 2026 22:37

Krishna2323 approved these changes Oct 20, 2026

View reviewed changes

melvin-bot Bot requested a review from chuckdries October 20, 2026 22:45

yuwenmemon requested a review from francoisl October 20, 2026 22:53

francoisl approved these changes Oct 20, 2026

View reviewed changes

yuwenmemon merged commit bc54f60 into main Oct 20, 2026
46 of 48 checks passed

yuwenmemon deleted the yuwen-683436-describeRuleAgentFallback branch October 20, 2026 23:38

yuwenmemon added a commit that referenced this pull request Oct 20, 2026

chore(rules): merge main after #103810 landed

0f9800a

OSBotify mentioned this pull request Oct 21, 2026

Deploy Checklist: New Expensify 2026-10-21 #104620

Closed

83 tasks done

applause-bot Bot mentioned this pull request Oct 21, 2026

Android & iOS - Rules - App does not scroll down to Describe field when field is focused #104648

Open

2 of 7 tasks

applause-bot Bot mentioned this pull request Oct 22, 2026

[$175] Full category description is displayed shortly instead of the rule title #104688

Open

2 of 7 tasks

MelvinBot mentioned this pull request Oct 22, 2026

[No QA] Docs updates for E/A#103810 Update New rule option descriptions in Workspace Rules #104795

Merged

38 tasks

melvin-bot Bot mentioned this pull request Oct 23, 2026

[Due for payment 2026-10-30] Payment issue for E/App PR#103810 #104872

Open

Conversation

yuwenmemon commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

codecov Bot commented Oct 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

yuwenmemon commented Oct 14, 2026

Uh oh!

yuwenmemon commented Oct 14, 2026

Uh oh!

Krishna2323 commented Oct 20, 2026

Uh oh!

Krishna2323 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026

Uh oh!

mitarachim commented Oct 21, 2026

Uh oh!

jponikarchuk commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 22, 2026

Uh oh!

MelvinBot commented Oct 22, 2026

Uh oh!

OSBotify commented Oct 23, 2026

Uh oh!

melvin-bot Bot commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

yuwenmemon commented Oct 12, 2026 •

edited

Loading

codecov Bot commented Oct 12, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 13, 2026 •

edited

Loading

Krishna2323 left a comment •

edited

Loading

jponikarchuk commented Oct 22, 2026 •

edited

Loading