Repository navigation
[No QA] Docs updates for E/A#103810 Update New rule option descriptions in Workspace Rules - #104795
Conversation
Co-authored-by: Yuwen Memon <[email protected]>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@trjExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted correction to the Workspace Rules article, updating three bullet descriptions under "How to add a rule from any tab" so they match the current New rule page copy in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This PR is a minor copy correction, so a single summary comment covers all feedback. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 122eb9b839
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Set field requirements** – Require specific expense fields or waive requiring them. | ||
| - **Apply expense defaults** – Update fields without the submitter doing anything. | ||
| - **Flag for review** – Notify when your conditions are met. | ||
| - **Set field requirements** – Require receipts, categories, and other fields. |
There was a problem hiding this comment.
When users compare this list with the New rule page, this bullet still does not match the current UI: RulesNewPage renders workspace.rules.newRule.requireFieldsDescription, whose value in src/languages/en.ts is Receipts, categories, etc., not Require receipts, categories, and other fields. Since this update is intended to synchronize the documented descriptions with the UI, use the actual translation text here.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Done in d9fe1709. The Set field requirements bullet now reads "Receipts, categories, etc.", which matches requireFieldsDescription in src/languages/en.ts:9234.
The PR description still quotes the old wording in its list of new descriptions. I couldn't edit the description from this run, so you may want to update that line.
Co-authored-by: Yuwen Memon <[email protected]>
|
A preview of your ExpensifyHelp changes have been deployed to https://6fc3448f.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.21-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Describe a rule from New rule and fall back to an agent rule shortened three option descriptions on the New rule page for all users, not only behind the
describeRulebeta. The Workspace Rules article still listed the old descriptions in "How to add a rule from any tab":This PR updates those three bullets to match the current UI copy in
src/languages/en.ts:The beta-only changes (the describe section, removing Describe agent rule, and the Require fields short title) are not documented, because they're still gated behind the
describeRulebeta.@yuwenmemon, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #103810
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari