Repository navigation
Conversation
Co-authored-by: MelvinBot <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://fcc6721e.helpdot.pages.dev ⚡️ Updated articles: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? cc @heyjennahay |
|
@heyjennahay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| - **Apply expense defaults** – Update fields without the submitter doing anything. | ||
| - **Describe agent rule** – Create flexible rules that run when you need. | ||
| - **Flag for review** – Notify when your conditions are met. | ||
| - **Require fields** – Receipts, categories, etc. |
There was a problem hiding this comment.
AI readiness / vague wording: "Receipts, categories, etc." uses "etc.", which the authoring guidelines call out as vague wording to avoid (HELP_AUTHORING_GUIDELINES.md Section 6). Spell out what Require fields can require instead of trailing "etc." — for example, "Require a description, attendees, or a receipt for an expense."
HelpDot Documentation ReviewOverall AssessmentThis PR updates three articles to document the new New rule page, where workspace admins pick from four templates or describe a rule in plain English for Concierge to build. The changes rename Describe agent rule to a describe box, add an Add agent rule row on the Agents tab, add a new How to have Concierge build a rule section, and rename the Set field requirements template to Require fields across all three files. The changes are consistent, well-structured, and align closely with the governance rules. Scores below reflect only the proposed diff. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Explanation of Change
Documents describing a rule on New rule. With Describe a rule from New rule and fall back to an agent rule, New rule lists four templates and then a describe box under "Or just describe it below". Concierge builds a standard rule from the description, or drafts an agent rule when it can't. That box replaces Describe agent rule, and the Agents tab gets an Add agent rule row. The Describe button inside the rule editors, from App#99624, is unchanged. The templates now read Require fields and use shorter descriptions, so the category article changes too.
On HOLD: merge after the
describeRulebeta is removed. Help docs go live on merge, and until then only beta accounts see this New rule page. The refusals that Web-E#56886 turns on aren't documented here.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/683436
PROPOSAL:
Tests
describeRulebeta on, follow the steps and confirm each label matches New rule.Offline tests
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari