[c3024]

Explanation of Change

The Vendor filter row shows when a workspace's connections turn the vendor feature on, but its picker only listed the policyVendors_ lists from OpenSearchVendorFiltersPage, which covers workspaces the user administers. A member whose workspace connections were loaded without a vendor list, for example from the workspace page, saw the row with only "No vendor".

The picker now lists the vendors from each eligible workspace's own connections (getMatchingVendors, the same source as the expense Vendor field), so the row and its list always come from the same data. With that, the OpenSearchVendorFiltersPage load is no longer needed, so the hook, action, read command and its two Onyx keys are removed. The backend command can be retired once this ships.

Fixed Issues

$ #103145
PROPOSAL:

Tests

1. As an admin, connect a workspace to QuickBooks Online with "Export company card expenses as" set to Credit card, and invite a member.
2. Sign in as the member. In Workspaces, create a second workspace and set it as the default workspace from its menu.
3. Go to Account > Troubleshoot > Clear cache and restart.
4. Go to Workspaces and open the QBO workspace.
5. Go to Spend > Filters > Vendor. Verify the QBO workspace's synced vendors are listed after "No vendor", with no loading spinner.
6. In Filters, set Workspace to the member's other workspace, then open Vendor. Verify only "No vendor" is listed.
7. Sign in as the admin and open Spend > Filters > Vendor. Verify the vendors are listed once each.
8. Pick a vendor that is set on an expense and apply. Verify only that expense is returned. Then pick "No vendor" and verify only expenses without a vendor are returned.

Screen.Recording.2026-10-06.at.5.38.51.PM.mov

• Verify that no errors appear in the JS console

Offline tests

1. As the member, open the QBO workspace, then go offline.
2. Open Spend > Filters > Vendor. Verify the synced vendors are still listed.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Beamanator]

@c3024 so you're removing all calls to OpenSearchVendorFiltersPage, eh? My codex is thinking with this change the user / member won't necessarily have the vendor list loaded into onyx unless they visit the workspace settings page first, so they could still see outdated vendor lists if they don't do that first - do you agree?

[eVoloshchak]

@codex, review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-14T19:20:24.342177Z	7133233	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[eVoloshchak]

@codex review

[chatgpt-codex-connector]

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[c3024]

@c3024 so you're removing all calls to OpenSearchVendorFiltersPage, eh? My codex is thinking with this change the user / member won't necessarily have the vendor list loaded into onyx unless they visit the workspace settings page first, so they could still see outdated vendor lists if they don't do that first - do you agree?

@Beamanator

Not outdated. Once a workspace's connections are loaded, each sync pushes the connections update to members live, so the list stays current. I checked this on staging. Not loaded, yes. A workspace the member hasn't opened isn't in the picker. But OpenSearchVendorFiltersPage didn't help there either, because the old picker also needed loaded connections and the command only returned workspaces the user administers.

This change now continues in #104351, so I'm closing this PR.