Repository navigation
[Payment due @abzokhattab] Add Share to the report More menu - #103141
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
# Conflicts: # src/components/MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions.tsx # src/libs/PopoverMenuSections.ts
# Conflicts: # src/components/MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions.tsx # src/libs/PopoverMenuSections.ts
|
done here, Share code from the Share menu shows only the QR code now |
|
@abzokhattab can you test for the ^ please |
This comment has been minimized.
This comment has been minimized.
|
Thanks for tackling it, i am reviewing now |
|
Question: When the user is offline, the Screen.Recording.2026-10-14.at.13.06.28.mov |
|
it's expected, the share is saved and sent once they're back online, even if they close the app, same as approving or submitting offline |
|
I see ... the changes LGTM .. also updated the screenshots |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.5.13-0 🚀
|
|
Help site update needed. I opened a draft docs PR: Docs updates for E/A#103141 Add Share to report More menu actions table Why: This PR adds a new feature. The More menu now has a Share option for all users, with no beta check. The "Additional report actions available from the More menu" table in Expense and Report Actions lists the More menu actions, but it doesn't include Share. Change: The docs PR adds one row for Share to that table. The row covers Share code, Refer a friend, and Copy URL, plus Share report for the submitter, approver, and workspace admin on expense reports that aren't Draft. I checked these labels against the dev web build. @allgandalf, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104380 |
Explanation of Change
Adds Share to the report More menu, with Share report, Share code, Refer a friend and Copy URL under it. Share report opens a page to pick one person and emails them the report. It shows on submitted expense reports for the submitter, the approver and workspace admins.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/685167
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari