You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[No QA] Fix max-lines lint, TypeScript and SplitTest failures on main - #104251
The lint / ESLint check job is failing on main because src/libs/Navigation/types.ts has 4001 lines, one over the max-lines limit of 4000.
#104177 removed the /* eslint-disable max-lines */ comment from the top of the file. On that branch the file was down to 3996 lines, so the comment was no longer needed. Meanwhile #103141 and #104020 merged to main and added 5 lines to the same file. Once #104177 merged, the file ended up at 4001 lines without the disable comment.
This PR adds /* eslint-disable max-lines */ back to the top of the file, the way it was before #104177. The file sits right at the limit, so trimming a line would break again on the next addition.
This PR also fixes the Jest failures on main in tests/actions/IOUTest/SplitTest.ts. Since #100166 merged, two tests fail on every PR:
updateSplitTransactions › should remove the new split transactions and restore the original expense with an error when the first split fails
updateSplitTransactions › should restore the selfDM chat preview when a new split moved to the selfDM fails
The test #100166 added (should keep the expense report totals unchanged when a split is reverted while offline) calls mockFetch?.pause?.() and never resumes. The fetch mock is recreated for each test, but the app's request queue is shared across the file. That test's last request stays stuck waiting on a response that never comes, so the requests from later tests queue behind it and never reach their own mock, and their failure handling never runs. The fix resumes the mock at the end of that test.
The same test also breaks the TypeScript check on main: it passes a betas option that createWorkspace, requestMoney and updateSplitTransactionsFromSplitExpensesFlow no longer accept. This PR replaces it with the current parameters (isVendorMatchingBetaEnabled, reportDrafts).
The SplitTest.ts changes are identical to #104256, so whichever PR merges second won't conflict.
Run npx eslint --max-warnings=0 src/libs/Navigation/types.ts and verify there are no errors.
Run npx tsc --noEmit -p tsconfig.json and verify there are no errors.
Run npx jest tests/actions/IOUTest/SplitTest.ts and verify all tests pass.
Verify the lint / ESLint check, TypeScript and Jest jobs pass on this PR.
Verify that no errors appear in the JS console
Offline tests
N/A, no runtime changes.
QA Steps
[No QA] Lint and test-only changes with no runtime changes.
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
I asked an AI agent to review the changes for accessibility issues and addressed its findings.
I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
I verified all new/changed elements have meaningful accessible names and roles.
I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
NicolasBonet
changed the title
[No QA] Split SettingsNavigatorParamList out of Navigation/types.ts to fix max-lines lint failure
[No QA] Re-add eslint-disable max-lines to Navigation/types.ts
Oct 16, 2026
NicolasBonet
changed the title
[No QA] Re-add eslint-disable max-lines to Navigation/types.ts
[No QA] Fix max-lines lint and SplitTest failures on main
Oct 16, 2026
NicolasBonet
changed the title
[No QA] Fix max-lines lint and SplitTest failures on main
[No QA] Fix max-lines lint, TypeScript and SplitTest failures on main
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
lint / ESLint checkjob is failing onmainbecausesrc/libs/Navigation/types.tshas 4001 lines, one over themax-lineslimit of 4000.#104177 removed the
/* eslint-disable max-lines */comment from the top of the file. On that branch the file was down to 3996 lines, so the comment was no longer needed. Meanwhile #103141 and #104020 merged tomainand added 5 lines to the same file. Once #104177 merged, the file ended up at 4001 lines without the disable comment.This PR adds
/* eslint-disable max-lines */back to the top of the file, the way it was before #104177. The file sits right at the limit, so trimming a line would break again on the next addition.This PR also fixes the Jest failures on
mainintests/actions/IOUTest/SplitTest.ts. Since #100166 merged, two tests fail on every PR:updateSplitTransactions › should remove the new split transactions and restore the original expense with an error when the first split failsupdateSplitTransactions › should restore the selfDM chat preview when a new split moved to the selfDM failsThe test #100166 added (
should keep the expense report totals unchanged when a split is reverted while offline) callsmockFetch?.pause?.()and never resumes. The fetch mock is recreated for each test, but the app's request queue is shared across the file. That test's last request stays stuck waiting on a response that never comes, so the requests from later tests queue behind it and never reach their own mock, and their failure handling never runs. The fix resumes the mock at the end of that test.The same test also breaks the TypeScript check on
main: it passes abetasoption thatcreateWorkspace,requestMoneyandupdateSplitTransactionsFromSplitExpensesFlowno longer accept. This PR replaces it with the current parameters (isVendorMatchingBetaEnabled,reportDrafts).The
SplitTest.tschanges are identical to #104256, so whichever PR merges second won't conflict.Neither change affects the app at runtime.
Fixed Issues
$ #104246
PROPOSAL: N/A
Tests
npx eslint --max-warnings=0 src/libs/Navigation/types.tsand verify there are no errors.npx tsc --noEmit -p tsconfig.jsonand verify there are no errors.npx jest tests/actions/IOUTest/SplitTest.tsand verify all tests pass.lint / ESLint check, TypeScript and Jest jobs pass on this PR.Offline tests
N/A, no runtime changes.
QA Steps
[No QA] Lint and test-only changes with no runtime changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A, no runtime changes.
Android: mWeb Chrome
N/A, no runtime changes.
iOS: Native
N/A, no runtime changes.
iOS: mWeb Safari
N/A, no runtime changes.
MacOS: Chrome / Safari
N/A, no runtime changes.