You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room #104412
Clicking a trip row, or its View button, opens the trip room on Spend the same way chat results open: in a wide panel on top of the table, on SEARCH_REPORT (search/view/:reportID). For a trip room that shows the trip summary with booking cards on top and the chat below. On mobile it slides in full width, and back returns to the table.
Admins who aren't in the trip room. The chat screen would fail its access check for them. When the user isn't in the room, open a read-only trip summary in the same wide panel instead: the same booking cards built from the search results' tripData, with no chat and no buttons, reading the search data the way MoneyRequestView does. When it opens, rerun the trip search for just that trip with the reportID filter so the data is fresh.
The read-only summary never opens the room, and its booking rows don't link into it.
Everything user-facing here is behind the TRAVEL_APPROVAL beta (Release 1, step 0).
Manual Test Steps
As a traveler, open Spend → Travel → Trips and click a trip. Verify the trip room opens in a wide panel over the table, with booking cards and chat.
Close it and verify the table is still there.
On mobile, tap a trip. Verify it opens full width and back returns to the table.
As a workspace admin not in a trip room, click that trip. Verify a read-only summary opens with booking cards, no chat and no buttons.
Automated Tests
A trip row opens the trip room for room members and the read-only summary for admins outside the room.
changed the title [-][Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/-][+][$250] [Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/+]on Oct 28, 2026
Activity
melvin-bot commentedon Oct 19, 2026
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)[-][Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/-][+][$250] [Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/+]melvin-bot commentedon Oct 28, 2026