Skip to content

[$250] [Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room #104412

Open

Description

@stitesExpensify

Part of the Approve Travel in New Expensify project

Main issue: #659261
Doc section: Design doc, Detailed Implementation → Release 2, step 2
Project: https://github.com/orgs/Expensify/projects/354

Blocked by: #104405, #693377, #693378

Feature Description

  • Clicking a trip row, or its View button, opens the trip room on Spend the same way chat results open: in a wide panel on top of the table, on SEARCH_REPORT (search/view/:reportID). For a trip room that shows the trip summary with booking cards on top and the chat below. On mobile it slides in full width, and back returns to the table.
  • Admins who aren't in the trip room. The chat screen would fail its access check for them. When the user isn't in the room, open a read-only trip summary in the same wide panel instead: the same booking cards built from the search results' tripData, with no chat and no buttons, reading the search data the way MoneyRequestView does. When it opens, rerun the trip search for just that trip with the reportID filter so the data is fresh.
  • The read-only summary never opens the room, and its booking rows don't link into it.

Everything user-facing here is behind the TRAVEL_APPROVAL beta (Release 1, step 0).

Manual Test Steps

  1. As a traveler, open Spend → Travel → Trips and click a trip. Verify the trip room opens in a wide panel over the table, with booking cards and chat.
  2. Close it and verify the table is still there.
  3. On mobile, tap a trip. Verify it opens full width and back returns to the table.
  4. As a workspace admin not in a trip room, click that trip. Verify a read-only summary opens with booking cards, no chat and no buttons.

Automated Tests

  • A trip row opens the trip room for room members and the read-only summary for admins outside the room.
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  2. changed the title [-][Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/-] [+][$250] [Approve Travel R2] Open trips from Spend, with a read-only summary for admins outside the trip room[/+] on Oct 28, 2026
  3. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  4. self-assigned this
    on Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions