Repository navigation
[Due for payment 2026-11-05] [$250] [Approve Travel R1] Trips table in Spend #104405
Description
Part of the Approve Travel in New Expensify project
Main issue: #659261
Doc section: Design doc, Detailed Implementation → Release 1, step 3
Project: https://github.com/orgs/Expensify/projects/354
Blocked by: #693360
Feature Description
Both trip column configs are empty today, and a trip search falls through to the expense view.
- Add
TYPE_CUSTOM_COLUMNS.TRIPandTYPE_DEFAULT_COLUMNS.TRIP:startDate,endDate,status,tripName,traveler,total. - View. Add a trip view before the expense view fallthrough, with its own
renderItem, like the expense report view. - Row. Add a trip row, wide and narrow, built like the expense report row: start date, end date, a
StatusBadge, trip name, the traveler's avatar and name, and the total in the trip's currency. - Header. Add trip headers for the columns above.
- Action. The row action is View. View and tapping the row both open the trip room (#104412 moves this into the Spend wide panel).
- No Approver column yet. It's added in #104417.
Everything user-facing here is behind the TRAVEL_APPROVAL beta (Release 1, step 0).
Manual Test Steps
- Sign in as a user with the beta who has several Expensify Travel trips.
- Open Spend → Travel → Trips.
- Verify each row shows start date, end date, status badge, trip name, traveler avatar and name, and total.
- Resize to a narrow layout (or use mobile) and verify the narrow row shows the same data.
- Tap View and verify the trip room opens. Go back, tap the row itself, and verify the same.
Automated Tests
- Trip rows render the right columns, badge and View action.
Activity
melvin-bot commentedon Oct 19, 2026
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)allgandalf commentedon Oct 20, 2026
trip search needs
shouldReturnTripRooms: truein the jsonQuery, without it type:trip stays the expense search[-][Approve Travel R1] Trips table in Spend[/-][+][$250] [Approve Travel R1] Trips table in Spend[/+]melvin-bot commentedon Oct 28, 2026
jponikarchuk commentedon Oct 29, 2026
Deploy Blocker #105339 was identified to be related to the PR #104562 that attempted to fix this issue.
melvin-bot commentedon Oct 29, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 29, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$250] [Approve Travel R1] Trips table in Spend[/-][+][Due for payment 2026-11-05] [$250] [Approve Travel R1] Trips table in Spend[/+]melvin-bot commentedon Oct 29, 2026
@suneox
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.25-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-05. 🎊
Contributor+ Checklist: The following checklist (instructions) needs to be completed before this issue can be closed:
If no checklist is needed for this issue, use the K2 [no checklist button].