Skip to content

[$175] [Approve Travel R3] Spend trips: Approver column, approval statuses and Review action #104417

Open

Description

@stitesExpensify

Part of the Approve Travel in New Expensify project

Main issue: #659261
Doc section: Design doc, Detailed Implementation → Release 3, steps 7 and 10
Project: https://github.com/orgs/Expensify/projects/354

Blocked by: #693378, #104412, #693385, #104413

Feature Description

  • Approver column. Add it to the trip columns.
  • Statuses. Trip status shows Outstanding while any booking is outstanding, and Rejected per #693385. Add both to the trip status filter.
  • Review action. There's no review action today; add one. Add a trip case to getActions: Review when the user is an approver on an outstanding booking, View otherwise. This works from the tripData in search results. Both open the trip room on Spend (#104412).
  • Offline. Handle Review before ActionCell's offline check, like View, so it stays enabled offline. Keep the green style.

Everything user-facing here is behind the TRAVEL_APPROVAL beta (Release 1, step 0).

Manual Test Steps

  1. As an approver, open Spend → Travel → Trips. Verify a trip waiting on you shows Outstanding, the Approver column, and a green Review button.
  2. Tap Review and verify the trip room opens in the wide panel.
  3. Go offline and verify Review is still enabled.
  4. As the traveler, verify the same trip shows View.

Automated Tests

  • Trip rows show Review for approvers with an outstanding booking, and View otherwise.
  • Review stays enabled offline.
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  2. changed the title [-][Approve Travel R3] Spend trips: Approver column, approval statuses and Review action[/-] [+][$175] [Approve Travel R3] Spend trips: Approver column, approval statuses and Review action[/+] on Oct 28, 2026
  3. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  4. self-assigned this
    on Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions