Skip to content

Feat: OS text size as fontScale and Windows file drop (#68, #72) - #615

Merged
b-re-w merged 5 commits into
developfrom
feat/68-72-fontscale-filedrop
Nov 13, 2026
Merged

b-re-w merged 5 commits into
developfrom
feat/68-72-fontscale-filedrop

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Closes #68
Closes #72

Not built locally; verified by the session's builder.

Verified

Local builder: ./kotlin test -m desktop (WindowTextScaleTest, NativeFileDropTest, WindowFrameTimeTest, MultiWindowTest pass), ./kotlin test -m macos. Dispatched CI on feat/p1T-ci-batch2 (this PR + #614 + #598): Kotlin/Native desktop run 43328500477 green (macOS, Linux); native renderer run 43345202790: iOS, Linux x64/arm64 static, macOS static, GraalVM Windows smoke, and the Windows x64 Kotlin/Native static renderer (Korean text self-check, every fr53_windows check) green.

…#68, #72)

WINDOW_REVISION moves to fa4781b, the merge of fork #156 (WindowPlatform.textScale,
WindowEvent.TextScaleChanged, the Windows and Linux readers). It also holds fork #157
(the Windows window's IDropTarget file drop for Kotlin/Native), #161 (the GraalVM
Win32 window module), #179 (Linux live size hints), #194 (Win32 set_resizable and
color scheme on an open window), #163/#165 (pointer button encoding), #189 (first
window inside the work area), #190 and #191 (Windows and Linux file dialogs) and
#193 (macOS one-step resize).

The Windows file dialogs are a C file of their own, win32_file_dialog.c, which the
windows-shared Kotlin/Native layer calls; build-windows.sh compiles it into the
native library and the Windows C check compiles it as well.

REVISION and MINGW_REVISION stay: the Compose modules did not change for this.
…68)

The Windows Kotlin/Native window, the native image's Win32 and X11 windows
draw their scene at Density(display scale, fontScale = the system's text
size), read from the window module when the window opens (Win32Loop.textScale,
the Text size slider through dxc_native_text_scale_percent, X11Window.textScale)
and followed through WindowEvent.TextScaleChanged while it is open. The shared
WindowTextScale in WindowEvents.kt holds the value for all of them. The native
image's Win32 record carries the slider's percent, which it turns into the
multiplier as the Kotlin/Native layer does. Other desktops get a stub of
dxc_native_text_scale_percent that answers 0.

The Linux Kotlin/Native window already reads the text size through its Zoom.
macOS has no public text size setting and the fork reports 1 there.

Covers FR-43 criterion 1 on the native side of Windows and Linux
(fr43_window_density_carries_the_os_text_size_as_font_scale,
fr43_os_text_size_change_reaches_the_window_while_it_is_open).
… (FR-27, #72)

The fork's Windows window now delivers FILES_ENTERED, FILES_DROPPED (paths in
the text, NUL between them) and FILES_EXITED through Win32Loop.drainEvents.
The Windows Kotlin/Native renderer links NativeFileDrop.kt as the Linux one
does, installs nativeFileDrop as platformFileDrop before the Host starts, and
hands every file event of each window (one or several) to routeFileDrop.

Covers FR-27's criterion that two dropped files arrive as one event with two
paths at the target under them, and nothing arrives where no target is
(fr27_windows_window_file_events_reach_the_target_under_them).
… case (#68, #72)

fa4781b has a duplicate WM_SETTINGCHANGE case in win32_window.c from fork #156 and #194 together; fork #195 (f9760f9) removes it and the fork's windows-shared jobs are green on it.
@b-re-w
b-re-w marked this pull request as ready for review November 13, 2026 03:33
@b-re-w
b-re-w merged commit e695787 into develop Nov 13, 2026
34 of 37 checks passed
@b-re-w
b-re-w deleted the feat/68-72-fontscale-filedrop branch November 13, 2026 03:33
b-re-w added a commit that referenced this pull request Nov 13, 2026
renderer/desktop/src/Win32Window.kt takes the resolution verified on feat/p1T-ci-batch2 (023fbd1): the window comes from the fork's graalvm-windows module and #615's OS text size reaches its Density.
b-re-w added a commit that referenced this pull request Nov 13, 2026
Takes the Windows files as verified on feat/p1T-ci-batch2 (run 43345202790, every fr53_windows check ok): the fork's real dxc_native_window_set_resizable / set_color_scheme / caption_dark (pin from #615) replace the link-time stand-ins, which are deleted, and the symbol test is back to each @SymbolName defined exactly once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant