Repository navigation
Feat: OS text size as fontScale and Windows file drop (#68, #72) - #615
Merged
Merged
Conversation
…#68, #72) WINDOW_REVISION moves to fa4781b, the merge of fork #156 (WindowPlatform.textScale, WindowEvent.TextScaleChanged, the Windows and Linux readers). It also holds fork #157 (the Windows window's IDropTarget file drop for Kotlin/Native), #161 (the GraalVM Win32 window module), #179 (Linux live size hints), #194 (Win32 set_resizable and color scheme on an open window), #163/#165 (pointer button encoding), #189 (first window inside the work area), #190 and #191 (Windows and Linux file dialogs) and #193 (macOS one-step resize). The Windows file dialogs are a C file of their own, win32_file_dialog.c, which the windows-shared Kotlin/Native layer calls; build-windows.sh compiles it into the native library and the Windows C check compiles it as well. REVISION and MINGW_REVISION stay: the Compose modules did not change for this.
…68) The Windows Kotlin/Native window, the native image's Win32 and X11 windows draw their scene at Density(display scale, fontScale = the system's text size), read from the window module when the window opens (Win32Loop.textScale, the Text size slider through dxc_native_text_scale_percent, X11Window.textScale) and followed through WindowEvent.TextScaleChanged while it is open. The shared WindowTextScale in WindowEvents.kt holds the value for all of them. The native image's Win32 record carries the slider's percent, which it turns into the multiplier as the Kotlin/Native layer does. Other desktops get a stub of dxc_native_text_scale_percent that answers 0. The Linux Kotlin/Native window already reads the text size through its Zoom. macOS has no public text size setting and the fork reports 1 there. Covers FR-43 criterion 1 on the native side of Windows and Linux (fr43_window_density_carries_the_os_text_size_as_font_scale, fr43_os_text_size_change_reaches_the_window_while_it_is_open).
… (FR-27, #72) The fork's Windows window now delivers FILES_ENTERED, FILES_DROPPED (paths in the text, NUL between them) and FILES_EXITED through Win32Loop.drainEvents. The Windows Kotlin/Native renderer links NativeFileDrop.kt as the Linux one does, installs nativeFileDrop as platformFileDrop before the Host starts, and hands every file event of each window (one or several) to routeFileDrop. Covers FR-27's criterion that two dropped files arrive as one event with two paths at the target under them, and nothing arrives where no target is (fr27_windows_window_file_events_reach_the_target_under_them).
b-re-w
marked this pull request as ready for review
November 13, 2026 03:33
b-re-w
added a commit
that referenced
this pull request
Nov 13, 2026
Takes the Windows files as verified on feat/p1T-ci-batch2 (run 43345202790, every fr53_windows check ok): the fork's real dxc_native_window_set_resizable / set_color_scheme / caption_dark (pin from #615) replace the link-time stand-ins, which are deleted, and the symbol test is back to each @SymbolName defined exactly once.
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68
Closes #72
WINDOW_REVISIONto fork fa4781b (merge of fork Make the X11 window the Linux default on the native-image path #156; also holds Win32 window: present through DirectComposition to remove live-resize black areas #157, CI: compile the Windows C sources with MSVC on every pull request #161, Docs: Right-click menu defaults to the OS menu, an app override replaces it (FR-33.1) #179, Docs: Take the macOS window radius from a style and version table with no private API (FR-19.7) #194, Integrate the fork's extended/window modules and delete the renderer's copies #163/Refactor: Use the fork's window modules and delete the renderer's copies #165, Fix: Release each frame's drawable on the Kotlin/Native macOS window #189, Fix: Keep Objective-C releases on the main thread on macOS K/N #190, Fix: Bound the footprint during a macOS resize, not only after #191, Feat: Link a skiko built without JAWT into the macOS native image #193).build-windows.shand the Windows C check compile the newwin32_file_dialog.c, which the windows-shared Kotlin/Native layer calls.Density(scale, fontScale = OS text size)and followTextScaleChanged, through a sharedWindowTextScale. The Linux Kotlin/Native window already did through itsZoom. macOS has no public setting; the fork reports 1.NativeFileDrop.kt, installsplatformFileDrop, and routes every window's file events to the node under them.Not built locally; verified by the session's builder.
Verified
Local builder: ./kotlin test -m desktop (WindowTextScaleTest, NativeFileDropTest, WindowFrameTimeTest, MultiWindowTest pass), ./kotlin test -m macos. Dispatched CI on feat/p1T-ci-batch2 (this PR + #614 + #598): Kotlin/Native desktop run 43328500477 green (macOS, Linux); native renderer run 43345202790: iOS, Linux x64/arm64 static, macOS static, GraalVM Windows smoke, and the Windows x64 Kotlin/Native static renderer (Korean text self-check, every fr53_windows check) green.