Skip to content

Feat: macOS window parity from fork #158 and #159 (#180, #146) - #617

Merged
b-re-w merged 8 commits into
developfrom
feat/180-146-macos-window-parity
Nov 13, 2026
Merged

b-re-w merged 8 commits into
developfrom
feat/180-146-macos-window-parity

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Refs #180
Refs #146

  • Moves WINDOW_REVISION to fork 5b91c514783 (fork Docs: Design for presenting the Win32 window through DirectComposition #158, Docs: Define live resize as zero frames drawn at a stale size (FR-19.8) #159). Kotlin only in the window modules: REVISION, C files and published modules unchanged.
  • Dock icon: the Kotlin/Native macOS renderer hands the icon asset to the fork's setApplicationIcon as premultiplied RGBA, on the single- and multi-window paths.
  • Clipboard: the fork's MacosWindowPlatform now provides LocalClipboard and LocalClipboardManager; the renderer's duplicate providers are removed.
  • Right click (FR-33.1): the window's own system edit menu stays off (editMenuOnRightClick = false), so Compose's NSMenu is the only menu and an app override shows only its own.
  • Dark mode already follows the live appearance (observeSystemAppearance); no read-once code remained. Minimum size reaches contentMinSize on both paths (tested). The GraalVM path already drops Control characters (insertableText); Command shortcuts are the fork's MacKeys.kt.

Needs the owner on hardware, which is why these say Refs and not Closes: a right click shows one NSMenu with Services (FR-33.1 criteria 1, 2 and 6), the Dock icon, and the appearance following System Settings live.

Not built locally; verified by the session's builder.

Pin

WINDOW_REVISION moves to fork b88429d011d (p1B: every fork job that builds or tests code is green). It also brings fork #185 (first Windows window inside the work area, Refs #510), #193 (macOS one-step resize, Refs #534), #190/#191 (Windows and Linux file dialogs), #197-#200, #201 (accessibility roles, for #473), #202 (Windows caption buttons and Snap Layouts) and #203 (GraalVM macOS appearance setter, for #536). #510 and #534 close after a check on the device. The 60 Hz macOS timers stay (#405): the fork does not yet ask AppKit to draw when the scene has held work.

Verified

Local builder on 13fc41d (develop merged in, fork pin b88429d011d published): ./kotlin test -m macos 45/45, ./kotlin test -m desktop 985/985. #180 and #146 stay open for the owner's check on a Mac (one right-click menu, Command shortcuts, Dock icon, live dark mode, clipboard).

)

Fork #158 (one right-click edit menu, Control characters dropped on GraalVM)
and fork #159 (setApplicationIcon, live appearance, explicit clipboard).
Kotlin only in the window modules, so REVISION and the build scripts stay.
…-click menu to the fork (#180, #146)

Dock icon through the window module's setApplicationIcon in premultiplied
RGBA (fr19_macos_dock_icon_pixels_are_premultiplied_rgba). Clipboard: the
window platform now provides LocalClipboard and LocalClipboardManager, so
the renderer's own copies are dropped on both paths. Right click: the
window's system edit menu stays off, leaving Compose's NSMenu as the one
menu (FR-33.1 criteria 1 and 3, fr33_macos_right_click_puts_up_one_menu_and_it_is_compose_s).
Minimum size reaches contentMinSize on open and on change
(fr19_macos_window_minimum_size_reaches_content_min_size).
…-window-parity

# Conflicts:
#	renderer/macos/src/MacosMultiWindow.kt
#	renderer/macos/src/MacosRenderer.kt
#	renderer/macos/src/MacosWindowBackend.kt
#	renderer/macos/test/MacosMultiWindowTest.kt
The fork's extended at 13aafb1 adds the IME caret fix (#197), the GraalVM Windows text scale multiplier (#198), the X11 PID and client machine (#199) and the macOS window host draining its own event log (#200). No new modules or C files.
The fork window now hands its scene the events it hears from its event handlers and draw path, so a click reaches the Host under NSApplication.run() with no timer; fr53_macos_click_reaches_host_without_a_turn_timer shows it. The 60 Hz turn timers stay: the scene's held coroutine work, animations and invalidations still run only in a turn or a draw, and nothing asks AppKit to draw for them, so their comments now say that instead of draining. The idle soak setting is still read once but no longer unset, since the window library's own soak reads DXC_WINDOW_IDLE_SOAK_SECONDS.
Adds fork #155, #201 (accessibility roles, for #473), #203 (GraalVM macOS appearance setter, for #536) and #202 (Windows caption buttons and Snap Layouts) on top of 13aafb1. No new C source; the new headers sit beside the files that include them.
Keeps develop's window appearance follower (#536) beside this branch's Dock icon and single right-click menu; the renderer's own clipboard locals stay removed because the fork's window supplies the clipboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant