Repository navigation
Feat: macOS window parity from fork #158 and #159 (#180, #146) - #617
Merged
Merged
Conversation
…-click menu to the fork (#180, #146) Dock icon through the window module's setApplicationIcon in premultiplied RGBA (fr19_macos_dock_icon_pixels_are_premultiplied_rgba). Clipboard: the window platform now provides LocalClipboard and LocalClipboardManager, so the renderer's own copies are dropped on both paths. Right click: the window's system edit menu stays off, leaving Compose's NSMenu as the one menu (FR-33.1 criteria 1 and 3, fr33_macos_right_click_puts_up_one_menu_and_it_is_compose_s). Minimum size reaches contentMinSize on open and on change (fr19_macos_window_minimum_size_reaches_content_min_size).
…-window-parity # Conflicts: # renderer/macos/src/MacosMultiWindow.kt # renderer/macos/src/MacosRenderer.kt # renderer/macos/src/MacosWindowBackend.kt # renderer/macos/test/MacosMultiWindowTest.kt
The fork window now hands its scene the events it hears from its event handlers and draw path, so a click reaches the Host under NSApplication.run() with no timer; fr53_macos_click_reaches_host_without_a_turn_timer shows it. The 60 Hz turn timers stay: the scene's held coroutine work, animations and invalidations still run only in a turn or a draw, and nothing asks AppKit to draw for them, so their comments now say that instead of draining. The idle soak setting is still read once but no longer unset, since the window library's own soak reads DXC_WINDOW_IDLE_SOAK_SECONDS.
Keeps develop's window appearance follower (#536) beside this branch's Dock icon and single right-click menu; the renderer's own clipboard locals stay removed because the fork's window supplies the clipboard.
b-re-w
marked this pull request as ready for review
November 13, 2026 03:41
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #180
Refs #146
setApplicationIconas premultiplied RGBA, on the single- and multi-window paths.MacosWindowPlatformnow providesLocalClipboardandLocalClipboardManager; the renderer's duplicate providers are removed.editMenuOnRightClick = false), so Compose's NSMenu is the only menu and an app override shows only its own.observeSystemAppearance); no read-once code remained. Minimum size reachescontentMinSizeon both paths (tested). The GraalVM path already drops Control characters (insertableText); Command shortcuts are the fork'sMacKeys.kt.Needs the owner on hardware, which is why these say Refs and not Closes: a right click shows one NSMenu with Services (FR-33.1 criteria 1, 2 and 6), the Dock icon, and the appearance following System Settings live.
Not built locally; verified by the session's builder.
Pin
WINDOW_REVISION moves to fork b88429d011d (p1B: every fork job that builds or tests code is green). It also brings fork #185 (first Windows window inside the work area, Refs #510), #193 (macOS one-step resize, Refs #534), #190/#191 (Windows and Linux file dialogs), #197-#200, #201 (accessibility roles, for #473), #202 (Windows caption buttons and Snap Layouts) and #203 (GraalVM macOS appearance setter, for #536). #510 and #534 close after a check on the device. The 60 Hz macOS timers stay (#405): the fork does not yet ask AppKit to draw when the scene has held work.
Verified
Local builder on 13fc41d (develop merged in, fork pin b88429d011d published): ./kotlin test -m macos 45/45, ./kotlin test -m desktop 985/985. #180 and #146 stay open for the owner's check on a Mac (one right-click menu, Command shortcuts, Dock icon, live dark mode, clipboard).