Repository navigation
Fix: Live Linux size hints and GraalVM Windows window from the fork (#407, #69) - #614
Merged
Merged
Conversation
…into feat/407-69-linux-hints-graal-window
Forwards setResizable to the fork's X11Window, whose size hints now follow resizable and minimum size changes on an open window. Covers the FR-53 criterion that a Window node's resizable and min-size props apply after open on Linux.
…windows module (FR-53, #69) The window object, its C calls, event reader, frame door and resize upcall move to the Compose fork's graalvm-windows module, whose frame time comes from its FrameClock on the monotonic clock. The renderer keeps only the Compose half and the configure and IsZoomed calls the fork's window does not make. Covers the frame-time criterion on the native image path; WindowFrameTime stays for the Kotlin/Native Windows renderer. Needs the fork pin at fa4781bafd8 or later.
This was referenced Nov 12, 2026
b-re-w
marked this pull request as ready for review
November 13, 2026 03:34
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407
Closes #69
setResizableto the fork'sX11Window(fork Docs: Right-click menu defaults to the OS menu, an app override replaces it (FR-33.1) #179), so resizable and minimum size changes on an open window update WM_NORMAL_HINTS. Test:fr53_linux_resizable_and_minimum_size_change_the_size_hints_of_an_open_windowinrenderer/linux/test/LinuxMultiWindowTest.kt. Ported from Feat: Linux live size hints (needs fork PR #179 pin first) (FR-53, #407) #449.graalvm-windowsmodule (fork CI: compile the Windows C sources with MSVC on every pull request #161): the window object, C calls, event reader,Win32Frames,Win32DrawCallbackand frame clock are removed here, andrenderer/desktopdepends onorg.thisisthepy.compose.window:graalvm-windows.WindowFrameTimestays for the Kotlin/Native Windows renderer. The layout and parity shell tests now read the fork'sWin32GraalWindow.kt.Needs the fork pin at fa4781bafd8 (branch feat/68-72-fontscale-filedrop) merged first. Until then
win32-window-layoutandwin32-renderer-parityfail on the missing fork file.Not built locally; verified by the session's builder.
Verified
In feat/p1T-ci-batch2 (with #615 and #598): Kotlin/Native desktop run 43328500477 green (Linux leg runs fr53_linux_resizable_and_minimum_size_change_the_size_hints_of_an_open_window); native renderer run 43345202790 green including the GraalVM Windows build and smoke test on the fork graalvm-windows module; local builder ./kotlin test -m desktop and -m macos. The merge with develop takes the Win32Window.kt resolution from that branch (023fbd1).