feat(event): score first-story detections with FAR and miss rates - #65
Draft
seonghobae wants to merge 1 commit into
Draft
feat(event): score first-story detections with FAR and miss rates#65seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Keep TDT first-story labels distinct from promoted event instances and require computed false-alarm, miss, and RMSE evidence against known truth.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#37 merged on protected main (
babd591). #45 kept ready (0007) but remains review-blocked (no independent APPROVE; still CONFLICTING after #37). Next no-0008 gap: first-story false-alarm/miss calibration in existingevent_core(does not recreate TDT/CHRONOS crates, does not wait on #48/#49/#53, and does not allocate 0008).refuse_first_story_as_instancenever promotes a detection to an instancedecide_first_storyuses an inclusive probability thresholdfirst_story_false_alarm_rateandfirst_story_miss_ratefail closed on empty, mismatched, or single-class streamsTest plan
first_story_contractfailed withE0432/E0599cargo test -p event_core --offlinecargo clippy -p event_core --all-targets --offline -- -D warningspython3 scripts/validate_documentation.pyandcheck_docstrings.pyDo not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.