Skip to content

feat(event): score TDT mention links with precision and recall - #66

Open
seonghobae wants to merge 2 commits into
mainfrom
agent/event-link-detection
Open

feat(event): score TDT mention links with precision and recall#66
seonghobae wants to merge 2 commits into
mainfrom
agent/event-link-detection

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

#45 remains preferred merge (0007) but is only locally blocked: hourly re-drafted it; this cycle marked it ready again. Exact-head required checks were cancelled by the draft and are re-queuing. No qualifying independent APPROVE (CodeRabbit COMMENTED only). #38 must not leapfrog #45.

Next no-0008 gap: TDT link-detection precision/recall in existing event_core (does not recreate TDT/CHRONOS crates, does not wait on #48/#49/#53/#65, and does not allocate 0008).

  • refuse_event_link_as_instance / refuse_event_link_as_transition never promote a detected pair
  • EventLinkPair refuses self-links and normalizes pair order
  • event_link_precision and event_link_recall fail closed on empty sets
  • Computed RMSE of known link targets is lower under calibrated scores than under an always-link detector

Test plan

  • RED: link_detection_contract failed with E0432/E0599
  • cargo test -p event_core --offline
  • cargo clippy -p event_core --all-targets --offline -- -D warnings
  • cargo test --workspace --offline
  • python3 scripts/validate_documentation.py and check_docstrings.py
  • exact-head required Checks (do not treat queued evidence as passed)

Do not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.

Keep detected same-event pairs distinct from promoted instances and
state transitions, and require computed precision, recall, and RMSE
against known-truth pair sets.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99e13ce0-1f3a-4fb0-be0f-d9aa02f88f73

📥 Commits

Reviewing files that changed from the base of the PR and between 7c29e7c and 633d41c.

📒 Files selected for processing (12)
  • CHANGELOG.md
  • DOCUMENTATION.md
  • crates/event_core/src/error.rs
  • crates/event_core/src/lib.rs
  • crates/event_core/src/link.rs
  • crates/event_core/tests/link_detection_contract.rs
  • docs/TRACEABILITY.md
  • docs/adr/0016-tdt-chronos-event-intelligence-boundary.md
  • docs/adr/README.md
  • docs/research/event-link-detection-calibration.md
  • docs/research/standards-and-literature.md
  • docs/validation/temporal-event-foundation.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

# Conflicts:
#	CHANGELOG.md
#	DOCUMENTATION.md
#	docs/TRACEABILITY.md
@seonghobae
seonghobae marked this pull request as ready for review August 20, 2026 10:25
@seonghobae

Copy link
Copy Markdown
Contributor Author

Reviewed and integrated current protected main without force-push.

Current head: 633d41c

Verification at this exact head:

  • cargo fmt --all -- --check
  • cargo test -p event_core --offline (5 unit, crate contract, 5 link-detection, 4 mention/instance, doctests)
  • cargo clippy -p event_core --all-targets --offline -- -D warnings
  • python3 scripts/check_workspace_contract.py
  • python3 scripts/check_docstrings.py
  • python3 scripts/validate_documentation.py
  • git diff --check

The link contract remains fail-closed: self-links and empty metric denominators reject, mention links cannot become instances or state transitions, and precision/recall are computed from normalized known-truth pairs. Please run protected current-head Checks and obtain the required independent approval before normal merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant