feat(event): score TDT mention links with precision and recall - #66
feat(event): score TDT mention links with precision and recall#66seonghobae wants to merge 2 commits into
Conversation
Keep detected same-event pairs distinct from promoted instances and state transitions, and require computed precision, recall, and RMSE against known-truth pair sets.
|
Warning Review limit reached
Next review available in: 15 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # CHANGELOG.md # DOCUMENTATION.md # docs/TRACEABILITY.md
|
Reviewed and integrated current protected main without force-push. Current head: Verification at this exact head:
The link contract remains fail-closed: self-links and empty metric denominators reject, mention links cannot become instances or state transitions, and precision/recall are computed from normalized known-truth pairs. Please run protected current-head Checks and obtain the required independent approval before normal merge. |
Summary
#45 remains preferred merge (0007) but is only locally blocked: hourly re-drafted it; this cycle marked it ready again. Exact-head required checks were cancelled by the draft and are re-queuing. No qualifying independent APPROVE (CodeRabbit COMMENTED only). #38 must not leapfrog #45.
Next no-0008 gap: TDT link-detection precision/recall in existing
event_core(does not recreate TDT/CHRONOS crates, does not wait on #48/#49/#53/#65, and does not allocate 0008).refuse_event_link_as_instance/refuse_event_link_as_transitionnever promote a detected pairEventLinkPairrefuses self-links and normalizes pair orderevent_link_precisionandevent_link_recallfail closed on empty setsTest plan
link_detection_contractfailed withE0432/E0599cargo test -p event_core --offlinecargo clippy -p event_core --all-targets --offline -- -D warningscargo test --workspace --offlinepython3 scripts/validate_documentation.pyandcheck_docstrings.pyDo not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.