feat(event): score TDT tracks with pair precision and switch rate - #68
Draft
seonghobae wants to merge 1 commit into
Draft
feat(event): score TDT tracks with pair precision and switch rate#68seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Keep hypothesized track assignments in existing event_core as measurement evidence. Refuse track-as-instance and track-as-transition promotion, compute pair precision/recall and identity-switch rate from known truth, and recover same-track targets with lower RMSE than an always-one-track detector.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#38 merged to protected main (
4d287a2). Preferred merge #45 was draft+CONFLICTING after that merge. This cycle rebased #45 onto origin/main (kept mention SQL from #38 and 0007 retention), force-pusheded1349f, and marked it ready. #45 is MERGEABLE BLOCKED: Checks queued, CodeRabbit COMMENTED only, no qualifying independent APPROVE. Do not self-approve or force-merge. Do not leapfrog #45 with #39.Next no-0008 gap: TDT tracking pair precision/recall and identity-switch rate in existing
event_core(does not recreate TDT/CHRONOS ormodel_selectioncrates, does not wait on #48/#49/#53/#65/#66/#67, and does not allocate 0008).refuse_track_as_instance/refuse_track_as_transitionnever promote a hypothesized tracktracking_pair_precisionandtracking_pair_recallfail closed on empty, mismatched, duplicate-mention, or pairless assignment streamstracking_identity_switch_rateis computed only over consecutive mentions that share a truth trackTest plan
0.5vs0.5always-one-track); fixture corrected so calibrated precision exceeds the naive mergecargo test -p event_core --offlinecargo clippy -p event_core --all-targets --offline -- -D warningscargo test --workspace --offlinepython3 scripts/validate_documentation.pyandcheck_docstrings.pyDo not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.