Skip to content

Preserve active streams during connection retirement - #938

Closed
mregrock wants to merge 2 commits into
ydb-platform:mainfrom
mregrock:codex/retain-streaming-connections
Closed

mregrock wants to merge 2 commits into
ydb-platform:mainfrom
mregrock:codex/retain-streaming-connections

Conversation

@mregrock

@mregrock mregrock commented Nov 5, 2026 •

Copy link
Copy Markdown
  • Bugfix

Discovery cleanup can cancel active synchronous streams; shutdown can deadlock or miss retired connections. Track streams until RPC completion, close retired connections safely at shutdown, and preserve replacement cache entries.

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.76%. Comparing base (2f73810) to head (0b74e7b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   82.69%   82.76%   +0.07%     
==========================================
  Files          99       99              
  Lines       12954    12962       +8     
  Branches     1266     1271       +5     
==========================================
+ Hits        10712    10728      +16     
+ Misses       1789     1785       -4     
+ Partials      453      449       -4     
Flag Coverage Δ
integration 80.41% <93.10%> (-0.01%) ⬇️
unit 50.40% <100.00%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ydb/aio/pool.py 75.31% <100.00%> (+0.10%) ⬆️
ydb/connection.py 81.99% <100.00%> (+1.07%) ⬆️
ydb/pool.py 85.71% <100.00%> (+1.83%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mregrock
mregrock marked this pull request as draft November 5, 2026 09:14
@mregrock mregrock closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant