Repository navigation
Stabilize bridge, NodeWarden and State Storage tests - #58181
Conversation
|
⚪
🟢 |
|
⚪
🟢 |
There was a problem hiding this comment.
🟡 Changes recommended
The verification read can itself return UNAVAILABLE and trigger an immediate assertion failure instead of retrying within the existing deadline while checking whether the update already committed.
1 open issue
What changed in this PR
Stabilizes bridge, NodeWarden and State Storage tests by waiting for observed state, controlling replica behavior explicitly, and retrying transient failures. These changes complement the linked runtime fixes and unmute 29 checks.
Changes:
- Replace timing-sensitive checks with configuration and state observations.
- Handle retryable bridge statuses and configure deterministic test behavior.
- Remove standard and AddressSanitizer test mutes.
| File | Description |
|---|---|
ydb/tests/functional/bridge/test_three_piles.py |
Retry aborted and unavailable bridge updates. |
ydb/tests/functional/bridge/test_mixed_storage.py |
Wait for storage pool growth. |
ydb/tests/functional/bridge/common.py |
Expand transient update status handling. |
ydb/tests/functional/bridge/chaos/test_bridge_chaos.py |
Treat aborted operations as transient. |
ydb/core/blobstorage/ut_blobstorage/bridge_mixed_storage.cpp |
Retry activation until nodes report bridge capability. |
ydb/core/blobstorage/ut_blobstorage/bridge_keep_flags.cpp |
Enable barrier validation for the relevant test. |
ydb/core/blobstorage/ut_blobstorage/bridge_failover.cpp |
Wait for configuration propagation before failover. |
ydb/core/blobstorage/ut_blobstorage/bridge_data_kind.cpp |
Explicitly enable barrier validation. |
ydb/core/blobstorage/ut_blobstorage/bridge_common.h |
Add bounded retries and generation-aware state switching. |
ydb/core/blobstorage/nodewarden/distconf_ut.cpp |
Explicitly trigger the rejected-binding scenario. |
ydb/core/blobstorage/nodewarden/blobstorage_node_warden_ut.cpp |
Wait for matching PDisk reports within a deadline. |
ydb/apps/bridge_skipper/ydbd_mock/tests/test_replication.py |
Use observed events and explicit replication controls. |
.github/config/muted_ya.txt |
Unmute 26 standard checks. |
.github/config/muted_ya_asan.txt |
Unmute three AddressSanitizer checks. |
Review effort: Balanced
| "No quorum to start propose/commit configuration", "Hop node disconnected", | ||
| # nodes are still rebinding after another pile has been disconnected | ||
| "No quorum for bridge configuration collection", | ||
| transient = response.operation.status in (StatusIds.ABORTED, StatusIds.UNAVAILABLE) or ( |
|
⚪
🟢 |
|
⚪
🟢 |
8e4c3e4 to
173b8ee
Compare
|
⚪
🟢 |

Stabilize NodeWarden and bridge tests with state-based waits, deterministic replica controls and retries of transient bridge statuses. Unmute 29 checks.
Validation: repeated C++/ASAN checks; StateStorage/SchemeBoard stress tests and root restart passed three runs each on the unchanged SDK; full chaos passed 23 steps and final data checks. The existing bridge shutdown regression test is preserved.