Skip to content

chore(tests): assert Firefox manifest warnings only in dedicated tests #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suveshmoza wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(tests): assert Firefox manifest warnings only in dedicated tests #2696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
257bcd7
test(wxt): assert Firefox manifest warnings only in dedicated tests
suveshmoza Oct 26, 2026
6f11565
Merge branch 'main' into test/firefox-manifest-warnings
nishu-murmu Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/wxt/e2e/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ export class TestProject {
private generateWxtConfig(inline: InlineConfig): InlineConfig {
return {
...inline,
suppressWarnings: {
firefoxDataCollection: true,
firefoxId: true,
...inline.suppressWarnings,
},
vite: async (...args) => {
const inlineVite = (await inline.vite?.(...args)) ?? {};
return vite.mergeConfig<vite.UserConfig, vite.UserConfig>(
Expand Down
5 changes: 4 additions & 1 deletion packages/wxt/src/internal-utils/testing/fake-objects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,10 @@ export const fakeResolvedConfig = fakeObjectCreator<ResolvedConfig>(() => {
hooks: {},
vite: () => ({}),
plugins: [],
suppressWarnings: {},
suppressWarnings: {
firefoxDataCollection: true,
firefoxId: true,
},
};
});

Expand Down
41 changes: 41 additions & 0 deletions packages/wxt/src/internal/__tests__/manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2233,6 +2233,47 @@ describe('Manifest Utils', () => {
});
});

describe('data_collection_permissions', () => {
it('should warn when building for Firefox without data_collection_permissions', async () => {
setFakeWxt({
config: {
browser: 'firefox',
suppressWarnings: {
firefoxDataCollection: false,
firefoxId: true,
},
},
});

await generateManifest([], fakeBuildOutput());

expect(wxt.logger.warnOnce).toHaveBeenCalledWith(
expect.stringContaining('data_collection_permissions'),
);
});
});

describe('firefox extension id', () => {
it('should warn when building for Firefox without an extension id', async () => {
setFakeWxt({
config: {
browser: 'firefox',
command: 'build',
suppressWarnings: {
firefoxDataCollection: true,
firefoxId: false,
},
},
});

await generateManifest([], fakeBuildOutput());

expect(wxt.logger.warnOnce).toHaveBeenCalledWith(
expect.stringContaining('Firefox requires extension ID'),
);
});
});

describe('stripPathFromMatchPattern', () => {
it.each([
['<all_urls>', '<all_urls>'],
Expand Down
Loading