[suveshmoza]

Overview

Asserted Firefox missing data_collection_permissions and extension-id warning in their own tests. Suppressed both warnings for the rest of the test suite, so they no longer log them. A test can still turn either warning back on.

Manual Testing

cd packages/wxt
bun run test run e2e/tests/zip.test.ts
bun run test run e2e/tests/hooks.test.ts
bun run test run e2e/tests/output-structure.test.ts
bun run test run e2e/tests/manifest-content.test.ts
bun run test run src/internal/__tests__/manifest.test.ts

Related Issue

This PR closes #2693

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	6f11565
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6ae1830abdf5105ceef62db2
😎 Deploy Preview	https://deploy-preview-2696--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7e7da895-d27a-44ef-8cb9-d4906d419ce7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nishu-murmu]

@suveshmoza
you're just adding tests and telling us to run bun run test
please provide a proper way for us to test this feature manually?

if this is firefox extension related issue, what to do exactly? how do we test this manually?

[suveshmoza]

@nishu-murmu Since this change spans the e2e test suite, I initially mentioned bun run test. I've updated the PR description with more specific test commands.

The change suppresses the warning across the test suite, and we explicitly verify that the warning is handled correctly in a dedicated test case.

[nishu-murmu]

You still didn't get what I'm trying to convey
I don't want to run some tests to check whether this works or not

I want to manually create this scenario and implement this firefoxDataCollection to true so that I'll be able to check.
Running just tests doesn't provide much insights

can you tell me how can spin up the extension (locally) for this particular scenario and able to test this warnings?

[suveshmoza]

Build wxt-demo (or a new project) for Firefox. WXT will log warnings for both missing fields. Then set suppressWarnings.firefoxDataCollection and/or suppressWarnings.firefoxId to true in wxt.config.ts, or provide values for the missing fields, WXT will no longer log warning.

[nishu-murmu]

Also the PR naming convention is not correct! Please follow the guidelines!

[pkg-pr-new]

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2696

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2696

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2696

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2696

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2696

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2696

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2696

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2696

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2696

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2696

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2696

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2696

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2696

wxt

npm i https://pkg.pr.new/wxt@2696

commit: 6f11565

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.44%. Comparing base (8fb1f6d) to head (6f11565).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
+ Coverage   80.32%   80.44%   +0.12%     
==========================================
  Files         139      139              
  Lines        4162     4162              
  Branches      961      961              
==========================================
+ Hits         3343     3348       +5     
+ Misses        720      716       -4     
+ Partials       99       98       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.