Skip to content

fix(orchestration): resume outstanding work after operator steers - #927

Merged
thewrz merged 13 commits into
mainfrom
fix/issue-914
Sep 25, 2026
Merged

thewrz merged 13 commits into
mainfrom
fix/issue-914

Conversation

@thewrz

@thewrz thewrz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

This was written agentically; verify its assertions:

Why

An operator steer could end the root turn while pushed results, ready successors, or PR obligations remained, requiring a second operator message to restart work.

What

Add an executable outstanding-work summary to the existing run-state helper. Derive obligations from the owned worker ledger, saved dispatch plan, accepted initial publications, and PR receipts. After a steer, resume Collect or dispatch while independent work remains; preserve the operator-only end-turn behavior from #906. Missing or ambiguous evidence requests reconciliation instead of claiming completion or duplicating an active owner.

The PR targets fix/issue-906 (#919). Its complete starting baseline 0073f2a55cbd65fed12d0dfbe1199e7f6674835a includes final #906 and initial #910; the adversarial review uses this baseline to exclude inherited code. Final #910 repairs are integrated in 1c90677fe05380a0929b1a2ba1956811317cf8b7, which passed the canonical full suite and final-head CI.

Testing

  • Failing boundary regressions before implementation; next-action 59/59 and a real worker-result producer-to-outstanding-consumer regression.
  • Static gates, size contracts, and generated-plugin rebuild.
  • AGENT_TEST_JOBS=8 AGENT_TEST_TIMEOUT_SCALE=2 tests/run-tests.sh on clean bbcace87e5f23937f26ccb01e01ac64cb16c5b23: ALL GREEN, exit 0; remote matches.
  • One adversarial review and findings disposition.
  • Final dependency integration and final-head GitHub CI.
  • Live mid-wave operator steer resumes the actual wave without a re-drive. Fixtures do not establish this live criterion.

Closes #914

🤖 Co-authored by Codex.

mergetest and others added 6 commits September 24, 2026 21:17
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 885126a7-db40-4b1b-bb87-07caf72fbc55

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

…e-914

# Conflicts:
#	tests/lint-helper-size.sh
#	tests/lint-skill-size.sh
#	tests/test-parallel-dispatch-contract.sh
#	tests/test-skill-size.sh
@thewrz

thewrz commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

One authorized adversarial review completed with Anthropic Claude claude-opus-5, effort xhigh, tools disabled. No second review was sent after repairs.

Immutable input: complete integration base 0073f2a55cbd65fed12d0dfbe1199e7f6674835a, reviewed head bbcace87e5f23937f26ccb01e01ac64cb16c5b23, diff SHA-256 670e0371ca9a5f4fe47515983aacf4da28050e01d792e3cb2979e9f901ae8838. Final integrated head: 1c90677fe05380a0929b1a2ba1956811317cf8b7.

All three findings are repaired:

  • P1: an accepted result suppresses stale queued redispatch, including an interruption before initial-publication metadata is recorded. Queue/publication state is reconciled; a rejected terminal attempt remains retryable.
  • P2: durable ownership rows take precedence over caller snapshots, so unknown activity requests reconciliation with waiting disabled.
  • P2: same-run v1 ownership cannot be accepted then ignored. It refuses with an evidence problem; unrelated old-run v1 rows do not block this run.

Regression: eight failing assertions before repair, next-action 69/69 afterward; the actual worker-result producer-to-outstanding-consumer check also passed. Finalized #910 is integrated. AGENT_TEST_JOBS=8 AGENT_TEST_TIMEOUT_SCALE=2 tests/run-tests.sh passed on the clean final head, exit 0, ALL GREEN; log /tmp/issue-914-final-full-1c90677fe05380a0929b1a2ba1956811317cf8b7.log, SHA-256 59b06372cf6cb9bffc977fc4b140d84e6f6653c419bebcea686ce8f590d61c78. Generated plugin rebuilt. Required final-head CI, all four suite shards, and aggregate gates are green.

The real mid-wave operator-steer acceptance criterion remains unverified. These regressions do not establish that live result. The PR remains draft.

mergetest and others added 5 commits September 24, 2026 23:01
Preserve both contracts using the previously verified integration resolution.

Co-Authored-By: Codex <[email protected]>
The file tree is unchanged; retain its measured size limits while carrying the predecessor landing corrections.

Co-Authored-By: Codex <[email protected]>
Preserve every execution, recovery, and baseline-exclusion rule while lowering the inherited reference-size limit.

Co-Authored-By: Codex <[email protected]>
Retain the identical candidate tree and all predecessor corrections.

Co-Authored-By: Codex <[email protected]>
Carry the #929 test synchronization repair through the remaining sprint stack; production files unchanged.

Co-Authored-By: Codex <[email protected]>
@thewrz
thewrz changed the base branch from fix/issue-906 to main September 25, 2026 06:34
@thewrz
thewrz marked this pull request as ready for review September 25, 2026 06:34
@thewrz
thewrz merged commit 95970a4 into main Sep 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(orchestration): resume outstanding wave obligations after an interjected operator message instead of ending the turn

2 participants