fix(pr-to-green): topologically order fan-out queues - #915
Conversation
Co-Authored-By: Codex <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
This was written agentically; verify its assertions: Adversarial review completed using Anthropic Claude
The live GitHub fan-out acceptance exercise remains outstanding; the five-PR controlled forge fixture passes. This comment records review and verification evidence, not completion of that remaining acceptance item. PR remains draft. 🤖 Co-authored by Codex. |
|
Live acceptance for #913 passed against five actual GitHub PRs, including three siblings and a grandchild. bash agentkit/skills/pr-to-green/scripts/pr-queue.sh \
--repo wrzonance/agent-kit --repo-root /tmp/agentkit-913-fanout.O3KAFp \
--pr 918 --pr 919 --pr 923 --pr 925 --pr 927 \
--write-confirmed-queue --no-providers --format tableExit 0, empty stderr. The persisted confirmed queue is |
This was written agentically; verify its assertions:
Why
Fan-out stacks produced by parallel-issues were rejected as ambiguous forks, forcing an operator to reconstruct a queue. This removes that queue-construction failure and the associated manual handoff.
What
Build the forge-derived queue in stable topological order: parents precede children, and eligible siblings are ordered by PR number. Preserve rejection of unknown bases, duplicate heads/PR identities, and cycles, with branch names in cycle diagnostics. The stacked-base merge gate is unchanged.
Prepare the shared unpublished 0.9.16 package version because 0.9.15 is already tagged.
Testing
bash tests/test-pr-queue.shfailed on the previous fork rejection.bash tests/test-pr-queue.sh: 74 assertions, zero failures; covers reversed forge input, a five-PR fan-out, persisted confirmed queue, cycles, duplicate heads, and unknown bases.AGENT_TEST_JOBS=2 tests/run-tests.sh: all 150 suites and static checks passed.claude-opus-5/xhigh, no P1/P2 findings.[918,919,923,925,927]from the actual forge graph; exit 0, no provider calls or forge mutations.Closes #913
🤖 Co-authored by Codex.