Skip to content

fix(pr-to-green): topologically order fan-out queues - #915

Merged
thewrz merged 1 commit into
mainfrom
fix/issue-913
Sep 25, 2026
Merged

thewrz merged 1 commit into
mainfrom
fix/issue-913

Conversation

@thewrz

@thewrz thewrz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

This was written agentically; verify its assertions:

Why

Fan-out stacks produced by parallel-issues were rejected as ambiguous forks, forcing an operator to reconstruct a queue. This removes that queue-construction failure and the associated manual handoff.

What

Build the forge-derived queue in stable topological order: parents precede children, and eligible siblings are ordered by PR number. Preserve rejection of unknown bases, duplicate heads/PR identities, and cycles, with branch names in cycle diagnostics. The stacked-base merge gate is unchanged.

Prepare the shared unpublished 0.9.16 package version because 0.9.15 is already tagged.

Testing

Closes #913

🤖 Co-authored by Codex.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 625bbd9b-7dc8-480d-ae84-9fca68326ec4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@thewrz

thewrz commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Adversarial review completed using Anthropic Claude claude-opus-5, effort xhigh, with tools disabled and only the immutable diff supplied. One provider execution; no rerun.

  • Reviewed base: 8f2a9b1fe4b53a0f7c9910b5cdf5808b3c05154f
  • Reviewed head and final verified head: bd7c2e7b47d1449eb9b8db4ebbd2eb384051cc13
  • Diff SHA-256: ca99925aa7a2c1964081331f617461bc6260c6e6efabd79fa0ab5482a1eee8bf
  • Result: no P1/P2 findings reported; no remediation needed.
  • Local verification: AGENT_TEST_JOBS=2 tests/run-tests.sh passed all suites and static gates on this head.
  • GitHub CI: all observed check runs completed successfully on this head, including static gates, four suite shards, aggregate gates/suites, and both CodeQL analyses. CodeRabbit reports its automatic review skipped; it is not the adversarial review.

The live GitHub fan-out acceptance exercise remains outstanding; the five-PR controlled forge fixture passes. This comment records review and verification evidence, not completion of that remaining acceptance item. PR remains draft.

🤖 Co-authored by Codex.

@thewrz

thewrz commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

Live acceptance for #913 passed against five actual GitHub PRs, including three siblings and a grandchild.

bash agentkit/skills/pr-to-green/scripts/pr-queue.sh \
  --repo wrzonance/agent-kit --repo-root /tmp/agentkit-913-fanout.O3KAFp \
  --pr 918 --pr 919 --pr 923 --pr 925 --pr 927 \
  --write-confirmed-queue --no-providers --format table

Exit 0, empty stderr. The persisted confirmed queue is [918,919,923,925,927]: #918 first, its children #919/#923/#925 in eligible numeric order, then #927 (child of #919). The artifact records repository wrzonance/agent-kit, providers [], actual head SHAs, and mode 0600. It was written in an isolated temporary coordinator; existing runtime state was untouched. No provider calls, merges, or forge mutations were performed. The controlled fixture is no longer the sole evidence for fan-out acceptance.

@thewrz
thewrz marked this pull request as ready for review September 25, 2026 05:51
@thewrz
thewrz merged commit 18466de into main Sep 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(pr-to-green): pr-queue.sh rejects fan-out stacks as an ambiguous fork; build a topological queue instead

1 participant