fix(chains): publish complete predecessor joins before dispatch - #925
Conversation
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
# Conflicts: # tests/lint-helper-size.sh # tests/lint-skill-size.sh # tests/test-parallel-dispatch-contract.sh # tests/test-skill-size.sh
# Conflicts: # tests/lint-helper-size.sh
# Conflicts: # tests/lint-helper-size.sh
Co-Authored-By: Codex <[email protected]>
Co-Authored-By: Codex <[email protected]>
|
One authorized adversarial review completed using Anthropic Claude Immutable input: complete integration base Findings disposition:
Regression: six failures before repair; create-worktree 112/112 after repair. Finalized parents #907, #905 and #911 are integrated. Final head |
Preserve both contracts using the previously verified integration resolution. Co-Authored-By: Codex <[email protected]>
The file tree is unchanged; retain its measured size limits while carrying the predecessor landing corrections. Co-Authored-By: Codex <[email protected]>
Preserve every execution, recovery, and baseline-exclusion rule while lowering the inherited reference-size limit. Co-Authored-By: Codex <[email protected]>
Retain the identical candidate tree and all predecessor corrections. Co-Authored-By: Codex <[email protected]>
The running record precedes initial git status and may still overlap its index lock. Wait for the synthetic command active-directory marker before the fixture commits; retain the HEAD-independent lease assertions. This removes the CI race seen while landing #925. Closes #929. Co-Authored-By: Codex <[email protected]>
This was written agentically; verify its assertions:
Why
A join could start with only one required predecessor, silently dropping selected work or using an incomplete base.
What
Persist each predecessor’s initial publication identity and consume the saved plan’s complete ordered predecessor set during setup. Assemble and publish every required input before implementation, preserve partial progress on resume, and hand merge conflicts to the existing sole-writer resolution workflow with combined-code validation.
The PR targets
fix/issue-907(#918). Its complete initial integration baseline is6bd083371c0e8da19479e59a159fc3b545b664ac, which also includes initial #905 and #911. GitHub’s displayed comparison includes those inherited changes; the immutable adversarial review uses that complete baseline to isolate #910. Completed parent repairs are integrated once at finalization in90063dced58c387577e86bd4ef8e65bd645da3b9, which passed the canonical full suite and final-head CI.Testing
AGENT_TEST_JOBS=8 AGENT_TEST_TIMEOUT_SCALE=2 tests/run-tests.shon clean42c43c5c15b630ed98a920e5e33b967102b40346: ALL GREEN, exit 0; pushed remote matches.Closes #910
🤖 Co-authored by Codex.