Skip to content

fix(tempo): include withdrawal fallback nonce - #385

Merged
tmm merged 1 commit into
mainfrom
struong/tempo-withdrawal-sender-tag-fix-main
Aug 6, 2026
Merged

fix(tempo): include withdrawal fallback nonce#385
tmm merged 1 commit into
mainfrom
struong/tempo-withdrawal-sender-tag-fix-main

Conversation

@struong

@struong struong commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the existing WithdrawalSenderTag.from API from #348 to derive nonce-bound Tempo Zone withdrawal sender tags.

Motivation

Zone user withdrawals hash sender || transactionHash || fallbackNonce. Omitting fallbackNonce returns a tag that cannot locate the parent-chain WithdrawalProcessed event.

The implementation follows the production Zone source at revision 689ffbe: Withdrawal::sender_tag defines the hash preimage, and WithdrawalRequested exposes fallbackNonce.

Changes

  • Required fallbackNonce in the existing WithdrawalSenderTag.from input.
  • Included the nonce as a packed uint64 for user withdrawals.
  • Preserved the canonical zero-sender deposit bounce-back tag.
  • Updated the existing runtime and type tests and added a patch changeset.

Testing

  • pnpm test --project tempo-unit --bail=1 src/tempo/WithdrawalSenderTag.test.ts
  • pnpm check:types
  • pnpm check
  • Verified the production vector returns 0xf1acbae45cd689281144042331e3379cf631a8d2db83057ccf38754a0b0108f2.

@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ox Error Error Aug 6, 2026 4:31pm

Request Review

@struong

struong commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Superseded by #384 so Viem main can consume the fix from its Ox 0.x dependency line.

@struong struong closed this Aug 6, 2026
@struong struong reopened this Aug 6, 2026
@struong
struong marked this pull request as ready for review August 6, 2026 16:58
@tmm
tmm merged commit 8100dbf into main Aug 6, 2026
12 of 23 checks passed
@tmm
tmm deleted the struong/tempo-withdrawal-sender-tag-fix-main branch August 6, 2026 17:00
@github-actions github-actions Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants