fix(tempo): backport withdrawal sender tag - #384
Closed
struong wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
struong
changed the title
Member
Author
|
Superseded by #385, which patches the existing WithdrawalSenderTag API on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the
WithdrawalSenderTagAPI introduced by #348 to Ox 0.x with the corrected nonce-bound Zone withdrawal algorithm.Motivation
Viem main uses Ox 0.14.x. Zone user withdrawals hash
sender || transactionHash || fallbackNonce; omitting the fallback nonce returns a tag that cannot locate the parent-chainWithdrawalProcessedevent.Changes
WithdrawalSenderTag.fromto the Ox 0.x Tempo exports.fallbackNonceas a packeduint64for user withdrawals.Testing
pnpm test src/tempo/WithdrawalSenderTag.test.tspnpm check:typespnpm check:tsdoc0xf1acbae45cd689281144042331e3379cf631a8d2db83057ccf38754a0b0108f2.