Repository navigation
Skip converged midpoint linear solve - #20
Closed
rogeriojorge wants to merge 1 commit into
Closed
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
rogeriojorge
changed the base branch from
agent/report-midpoint-nonconvergence
to
main
July 13, 2026 04:39
rogeriojorge
changed the base branch from
main
to
agent/report-midpoint-nonconvergence
July 13, 2026 04:39
rogeriojorge
marked this pull request as ready for review
July 13, 2026 04:41
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
Author
|
Squashed into #18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lax.condThis is stacked on #19. It changes one source file with a net two-line increase. The Newton criterion, Eisenstat–Walker forcing term, GMRES configuration, maximum iterations, and converged solution are unchanged.
Motivation
The Newton loop previously called GMRES before testing
norm < 1. Every successful midpoint step therefore ended with a redundant zero-iteration linear solve. A zero-iteration Krylov solve still applies the Jacobian-vector operator to form true residuals, which is expensive for the Fourier–Hermite RHS.A
33x33,4^3Orszag–Tang one-step profile overdt=1e-3 ... 1e-1found that the useful Newton solves normally required one FGMRES iteration (at most two), followed in every case by a converged check whose GMRES result was discarded.Performance
Five fixed midpoint steps,
33x33,4^3, CPU, median of five cached runs:1.116 s -> 0.736 s(34% reduction)0.324 s -> 0.168 s(48% reduction)Relative total-energy drift remained exactly
1.211254265768263e-16in all comparisons.Validation
pytest -q: 5 passedruff check spectrax/midpoint_solver.py tests/test_simulation_runs.py: passedgit diff --check: passed