Skip to content

Expose solver failure result - #14

Closed
rogeriojorge wants to merge 2 commits into
agent/structure-diffrax-statefrom
agent/expose-solver-result
Closed

rogeriojorge wants to merge 2 commits into
agent/structure-diffrax-statefrom
agent/expose-solver-result

Conversation

@rogeriojorge

Copy link
Copy Markdown
Member

Summary

  • expose Diffrax's throw option through simulation
  • return sol.result as solver_result
  • test the non-throwing path and assert successful integration

This lets batch and distributed runs avoid a host exception callback while retaining an explicit, machine-checkable failure status.

Validation

  • pytest -q (3 passed)
  • throw=False returns RESULTS.successful for the default simulation

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
spectrax/_simulation.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rogeriojorge
rogeriojorge marked this pull request as ready for review July 13, 2026 03:47
@rogeriojorge
rogeriojorge force-pushed the agent/expose-solver-result branch from d4870d9 to aa02e2f Compare July 13, 2026 05:17
@rogeriojorge
rogeriojorge changed the base branch from main to agent/structure-diffrax-state July 13, 2026 05:17
@rogeriojorge
rogeriojorge force-pushed the agent/structure-diffrax-state branch from 369c3b3 to 1dc9820 Compare September 26, 2026 21:11
@rogeriojorge

Copy link
Copy Markdown
Member Author

The throw option and solver_result moved into #50, which edits the same diffeqsolve lines; the state-layout part stays in #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant