Repository navigation
Use SOLVAX Newton-Krylov for midpoint solves - #27
Closed
rogeriojorge wants to merge 1 commit into
Closed
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
rogeriojorge
marked this pull request as ready for review
July 13, 2026 14:57
rogeriojorge
force-pushed
the
agent/correct-midpoint-time
branch
from
July 16, 2026 14:13
f17c2f0 to
ab30ce3
Compare
rogeriojorge
force-pushed
the
agent/solvax-newton-midpoint
branch
from
July 16, 2026 14:13
5c23eb9 to
db8a2fe
Compare
Member
Author
|
Squashed into #21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newton_krylovImplicitMidpointThis retains the midpoint rule, step limits, Krylov restart controls, and Diffrax failure result. The simplified PR now changes only
midpoint_solver.py.Why
SOLVAX owns the generic PyTree Newton–Krylov implementation, including true final residual checks and linear-solve diagnostics. Keeping a second nonlinear solver in SPECTRAX duplicates logic and makes preconditioning and distributed inner products harder to maintain.
The nonlinear stopping criterion is:
linear_rtolandlinear_atolindependently control each GMRES solve. The former SOLVAX #14 prerequisite is included in released SOLVAX 0.8.x.Validation
ruff check spectrax/midpoint_solver.pyruff format --check spectrax/midpoint_solver.py3.50e-11inCk,6.38e-11inFk2.51e-14(Evaluate implicit RHS at midpoint time #26) versus1.21e-16(this PR)The additional cost is the initial reference and true final residual evaluation. The collision/diffusion preconditioner remains a separate follow-up rather than weakening convergence reporting here.