Repository navigation
Handle infinite and fixed bounds in ALM inner solves - #185
Open
rogeriojorge wants to merge 1 commit into
Open
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ALM inner solver's finite-interval transform produces NaNs for one-sided bounds such as
(0, inf)and for fixed coordinates where lower equals upper. These bounds were accepted by the former JAXopt entry point, which remains available as an alias.Handle unbounded and fixed coordinates explicitly and reflect one-sided coordinates at their finite endpoint. Preserve the existing finite-interval transform. Regression tests exercise actual ALM updates with mixed bound types and boundary starts.
Validation:
tests/test_augmented_lagrangian.py— 28 passed, including seven new bound cases.@gftd13 please review and test one-sided and fixed bounds in existing ALM callers, including parameters initialized exactly at a bound.