Repository navigation
Fix single-stage coil and surface optimization - #184
Open
rogeriojorge wants to merge 3 commits into
Open
rogeriojorge wants to merge 3 commits into
rogeriojorge wants to merge 3 commits into
Conversation
rogeriojorge
marked this pull request as ready for review
October 24, 2026 00:21
rogeriojorge
marked this pull request as draft
October 24, 2026 03:57
rogeriojorge
force-pushed
the
fix/single-stage-validation
branch
from
October 24, 2026 04:02
65dafee to
015b504
Compare
Member
Author
|
@gftd13 I reduced this to the required fixes directly on your branch, with no main merge or argument parser. The example retains its globals and structure. Objective values and gradients match the validated results; the globals-only reload also reproduces the VMEX edge iota of 0.409839. Please review and test the boundary-mode controls, iota-fit safeguard, and VMEX export with your inputs. |
rogeriojorge
marked this pull request as ready for review
October 24, 2026 09:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix boundary-mode selection, the QS/iota objectives, and flux-matched VMEX export directly on
gftd/single_stageat67f26c4. No merge from main.The original example keeps its structure and top-level globals, with no argument parser. Changes are limited to three physics modules, the example, focused regression tests, and two small initial-condition files. Loss infrastructure, ALM, dynamics, dependencies, workflows, and other examples are unchanged.
The active objective values and full gradients match the validated implementation exactly at the initial state and saved mode-1/2/3 states. All 64 targeted field, boundary, flux, objective, and derivative tests pass. Fresh-run and restart checks pass. Reloading mode 3 through the globals-only example runs VMEX successfully: edge iota 0.409839, aspect 3.63559, and nine diagnostic figures. The same saved state has independently checked equilibrium QS mean-square 4.53e-5 and coil RMS B·n/B 3.66e-4.
CI: Python 3.11 passes. Python 3.12 fails four unchanged Boozer-compaction tests on roundoff differences of 2.22e-16. Main's separate test-tolerance fix is excluded from this PR.
@gftd13 please review and test the boundary-mode globals, iota-fit safeguard, and VMEX export with your inputs. For continuation, edit
RESTART_FROM,restart_filepath,output_filepath, andSURFACE_MPOL/NTOR. At mode 3 useQS_WEIGHT=1e4andIOTA_MPOL=IOTA_NTOR=8.