Repository navigation
Preserve initialized loss dependencies and avoid cached JAX tracers - #183
Open
rogeriojorge wants to merge 3 commits into
Open
rogeriojorge wants to merge 3 commits into
rogeriojorge wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiplying an initialized custom loss drops its dependencies, so accessing the weighted loss's starting DOFs raises KeyError. Calling a multiargument loss under JIT before reading its starting DOFs can also cache a tracer and later raise UnexpectedTracerError. Preserve dependencies when scaling a loss and evaluate cached DOF initialization at compile time.
Validation: tests/test_multiobjectives.py — 7 passed, 1 existing expected failure, including regressions for both errors, composite initialization under JIT, and gradients with shared dependencies.
@gftd13 please review and test weighted losses and first-call JIT behavior in the single-stage optimization workflow.