Repository navigation
Correct surface flux quadrature and add coil vector potential - #182
Open
rogeriojorge wants to merge 3 commits into
Open
rogeriojorge wants to merge 3 commits into
rogeriojorge wants to merge 3 commits into
Conversation
gftd13
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The surface flux helpers used vector potentials at polygon vertices with chord displacements, which introduces quadrature error and falsely closes half-period toroidal arcs. They now integrate A·dx using analytic surface tangents and periodic angular quadrature, dropping duplicated endpoints.
poloidal_fluxrequires a full torus, and both helpers document their signed loop orientation.Add the Cartesian filament vector potential to
BiotSavartusing the same coil quadrature and current normalization as its magnetic field. This enables flux matching when exporting optimized coil boundaries to VMEC/VMEX.Validation: 58 tests passed (
ESSOS_CPU_DEVICES=1 JAX_ENABLE_X64=1 python3.11 -m pytest -q tests/test_fields.py tests/test_surface_flux.py). Coverage includes analytic toroidal/vertical fields, open and closed angular grids,curl(A)=B, independent disk flux integration, and shape/current derivatives checked against finite differences.@gftd13 Please review and test these helpers in the single-stage boundary export workflow, including the signed loop flux conversion to VMEC
PHIEDGE.