Repository navigation
Keep Boozer splines continuous and avoid duplicate m=0 storage - #168
Open
rogeriojorge wants to merge 5 commits into
Open
rogeriojorge wants to merge 5 commits into
rogeriojorge wants to merge 5 commits into
Conversation
rogeriojorge
marked this pull request as ready for review
October 20, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep radial splines continuous in float64, and store the theta-independent m=0 channel once. The cubic and independent orbit-energy regressions pass. Python 3.11/3.12 CI and coverage are green. Two existing files change; no new files.
ARIES CPU timings with JAX 0.12.0.1, versus the original float32 code:
Resident table storage rises 1.4% in this case, rather than doubling. Direct Fourier execution is unchanged. These measurements do not guarantee performance on every workload or device.
With identical births, the 500-particle loss count changes from 75 to 63; tightening the new tracer tolerance from 3e-7 to 3e-8 gives 60. These are numerical sensitivity checks, not a confinement improvement or a converged loss estimate. Keep unmerged for review.