Repository navigation
chore: adding workflows and templates, updating documentation - #22
Merged
Merged
Conversation
… links Untrack Unity mono crash dumps (~235 MB), ros2_ws install/log build output, CMake build artifacts, a vim swap file, compiled Python caches, and the PX4-Autopilot / ws_sensor_combined submodule gitlinks that had no .gitmodules entry and produced empty directories on clone. Add ignore rules so these artifacts stay untracked.
Resolve the leftover Unity-Simulation merge conflict markers in the team list, replace the placeholder clone URL with the real repository URL, point the license link at LICENSE.md, remove commented-out text left over from another project, and fix spelling errors.
…eoConfigImages The file mixed tab and space indentation on two lines, so it raised a TabError and could not run at all. Replace the tabs with spaces to match the surrounding block.
logging, sys, signal, and os are Python standard library modules, not rosdep keys. rosdep could never resolve them, which broke dependency installation for the package.
Add merge conflict marker, YAML/JSON/Python syntax, filename case, large file, trailing whitespace, and end-of-file checks. Run 'pip install pre-commit && pre-commit install' to enable on commit.
Apply the pre-commit whitespace fixers once across the active source directories so the sanity check passes without broad exclusions. Whitespace-only; no code changes. DRON_Interface/ (Unity-generated) and senxor/ (vendored) are excluded from the fixers.
Validate PR titles against Conventional Commits with amannn/action-semantic-pull-request on opened, reopened, edited, and synchronized pull requests. The squash commit reuses the PR title, so the check keeps history clean. Exclude the vendored Ros2ForUnity libraries from the large-file check.
Run all pre-commit hooks in check mode on pull requests and pushes to main. Catches merge conflict markers, malformed YAML and JSON, broken Python syntax, case-conflicting filenames, oversized files, and whitespace issues before review.
Apply subsystem labels (ros2, autonomy, stereovision, sensors, visualization, documentation, ci-cd) from .github/labeler.yml when a pull request touches the matching paths. Uses pull_request_target so labels work for fork PRs; the workflow never checks out PR code.
Build ros2_ws with colcon in the ros:humble-ros-base container, install dependencies with rosdep, and run colcon test with a verbose result summary. Tests are non-blocking until the legacy packages pass ament lint. Runs only when ros2_ws or the workflow itself changes.
Weekly and per-PR security scanning for the Python packages and the Unity C# scripts. C++ is skipped because the standalone C++ targets are not buildable in CI without a full px4_ros_com tree.
Weekly grouped updates for workflow actions with Conventional Commit-compatible titles. Pip is not configured because the ROS packages declare dependencies in package.xml (handled by rosdep) and their setup.py files pin nothing.
Add structured issue forms (bug, feature, hardware, test report), a concise PR template with software and hardware validation checkboxes, and a contributing guide covering setup, branches, Conventional Commits, review, squash merging, and labels.
Neither cv2 nor spidev is a rosdep key (verified against the rosdistro rosdep database), so rosdep install fails without skipping them. Note the manual pip fallback in the contributing guide.
we never update them anyway
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
replacing with python3-colcon-common-extenstions
Add matplotlib to the rosdep --skip-keys list. Plain 'matplotlib' has no rosdep entry (only python3-matplotlib does), so dependency resolution failed on thermal_cam. Unexpected rosdep failures still fail the job; only the documented known-invalid keys are skipped.
Match the ROS 2 CI workflow: matplotlib has no rosdep key, so the local setup command skips it and the pip fallback list includes it.
Cut the layout, check, scope, and label reference tables in favor of the files that are the source of truth (.github/labeler.yml, the workflows). Fix setup so it actually works on a fresh machine (source ROS, rosdep init/update) and describe merge policy as policy. Fix README poster alt text, table-of-contents label, and the Getting Started dependency pointer.
The workspace contains legacy and hardware-specific packages that do not build cleanly in generic CI, so rosdep, colcon build, colcon test, and result reporting use step-level continue-on-error instead of blocking pull requests. Failures stay visible in the job log and step UI. Unrelated checks are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.