Repository navigation
ci(wasm): publish the wasm bundles on v* tags, like publish-cvcpkg - #592
Merged
Merged
Conversation
publish-cvcgl-wasm (libcvc + cvcgl + the cvcgl-examples gallery for wasm-mt) and publish-pycvc-gl-wasm (pycvc-gl-cp312 for wasm) were dispatch-only, so a release tag published the native family but left wasm behind until someone dispatched them by hand (3.5.0's wasm went out a day after the tag). - Both now also run on `push: tags: ['v*']`, the trigger publish-cvcpkg.yml uses, and publish on a tag push. - Manual dispatch is unchanged: still a dry run by default, dry_run=false publishes. publish-cvcgl-wasm reads an explicit job-level DRY_RUN (true only for a dispatch with dry_run checked) instead of an inputs.dry_run that is empty on a push; publish-pycvc-gl-wasm's publish step gates on `github.event_name == 'push' || inputs.dry_run == false` instead of relying on null == false coercion. - pycvc-gl-wasm compiles cvc + cvcGL from source, so running both on the same tag does not race on publish-cvcgl-wasm's bundles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A release tag publishes the native cvcpkg family (
publish-cvcpkg.ymlruns onv*), but the two wasm publishes were dispatch-only. 3.5.0's wasm bundles went out a day after the tag, from a manual run. This makes them tag-triggered like the rest:publish-cvcgl-wasm.yml+ push: tags: ['v*']; a tag push publishespublish-pycvc-gl-wasm.yml+ push: tags: ['v*']; a tag push publishesdry_run=falsepublishes.publish-cvcgl-wasmreads a job-levelDRY_RUN, which is true only for a dispatch withdry_runchecked. Before, it read aninputs.dry_runthat's empty on a push.publish-pycvc-gl-wasm's publish step gates ongithub.event_name == 'push' || inputs.dry_run == false. Before, it relied onnull == falsecoercion.publish-pycvc-gl-wasmcompiles cvc + cvcGL from source and never installs the published cvcgl wasm bundle, so both can run on the same tag.Merge this before tagging
v3.5.1(#590), so that tag publishes wasm too.