Skip to content

test(smoke): wait liveTimeout for blob soft navigation URL (v0.6.9) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnfssc merged 2 commits into from
Nov 5, 2026
Merged

test(smoke): wait liveTimeout for blob soft navigation URL (v0.6.9) #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c83f7ba
test(smoke): wait liveTimeout for blob soft navigation URL
tnfssc Nov 5, 2026
d2cce2e
chore(release): v0.6.9
tnfssc Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "github-html-preview",
"description": "Safely preview public HTML files and pull-request changes on GitHub",
"private": true,
"version": "0.6.8",
"version": "0.6.9",
"type": "module",
"scripts": {
"dev": "wxt",
Expand Down
4 changes: 3 additions & 1 deletion smoke/live.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ test('current GitHub blob UI renders repository CSS in a sandboxed preview', asy
});
await expect(nextFile).toBeVisible({ timeout: liveTimeout });
await nextFile.click();
await expect(page).toHaveURL(/\/getting-started\/index\.html$/);
await expect(page).toHaveURL(/\/getting-started\/index\.html$/, {
timeout: liveTimeout,
});

const refreshedFrame = page
.locator(
Expand Down
8 changes: 8 additions & 0 deletions wisdom/live-smoke-github-outage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Live blob smoke: GitHub 504s and slow soft navigation

Run [42047432893](https://github.com/tnfssc/github-html-preview/actions/runs/42047432893) failed all three attempts of the blob test during GitHub degradation, not an extension defect.

- Attempts 1–2: error context shows GitHub's "504 Gateway Time-out" page, so no Preview tab existed. No test change can help; retries already cover this.
- Retry 2: every Preview assertion passed. After clicking `getting-started/index.html` in the file tree, GitHub's `_file_tree`/`_layout` calls returned but the blob request was still pending, so the SPA URL had not changed when `toHaveURL` hit Playwright's 5s default.

Fix: `toHaveURL` now uses `liveTimeout` (30s) like every other live wait. Assertions, retries and product behavior unchanged. When a live smoke fails, read each attempt's `error-context.md` snapshot first: a GitHub error page means outage, not regression.
Loading