Repository navigation
report --markdown: before/after tables for documenting an intended change - #98
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
renderdiff report <out> --markdown <file>writes, fromresults.jsonand without a browser, one## <route>section per route. Each section has the before (right) and after (left) URLs and a| Width | Before | After |table that links each width's full-page shots, with(h±Npx)when the heights differ and the error message in place of an errored shot.Map.groupBy(results, name), as the report sidebar does. Image links come fromimages.left/rightand are made relative to the Markdown file's directory (POSIX separators,encodeURI).--shots-onlywas dropped. Running with--threshold 0 --no-recheckalready skips the exit-1 failure and the right-side reload, and the compare left after that is cheap next to capture. A real shots-only mode would need a new result shape that report.html, evidence.html,--rerun-failed,mergeand--acceptwould all have to handle.--helpand the usage error, README, docs/output.md (## markdown), skill reference.md and SKILL.md.Verification:
npm run typecheck,lint,format:check,npm test(359 pass) andnpm run test:visual(389 pass) locally on macOS. A new unit test runs the CLI against a hand-made out dir whose name contains a space. It checks that Before links the right image and After the left, that the height delta appears only on its row, the width order, and the error row.🤖 Generated with Claude Code