Repository navigation
Let a sparse page vouch for itself with data-renderdiff-rendered - #105
Merged
Merged
Conversation
A one-viewport fixture page with a few dozen chars of text was refused as "page did not render": the gate can't tell a page sparse on purpose from one that never mounted. A visible element marked data-renderdiff-rendered now counts as rendered content, and both refusals (run and probe) name the threshold, the marker, and where it must not go. Fixes #100 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
A one-viewport fixture page with 47 chars of text was refused as
page did not render on either side. The render gate (under 200 chars of text and no visible media) can't tell a page that is sparse on purpose from one that never mounted, so the page now says so itself.src/capture.ts: a visible element (≥ 1024px², like the media check) markeddata-renderdiff-rendered, anywhere on the page, counts as rendered content.src/run.ts/src/probe.ts: both refusals append one hint naming the threshold, the marker, and the warning to put it on the page's own content, not the layout shell (a shell marker would pass a page that never mounted).skills/renderdiff/reference.mderror row (bypass + placement warning) and masks table,docs/how-it-works.md,docs/scoping.md.Verification
npm run typecheck,npm run lint,npm run format:check: cleannpm test: 359/359npm run test:visual: 390/390. The new test runs/blankwith abeforeShotthat marks its paragraph, and checks that it's compared at 0 diff. The existing/blankrefusal tests also now assert that the message names the threshold and the marker.🤖 Generated with Claude Code