Repository navigation
CI smoke check runs sources instead of the built npm bundle - #2
Open
dipeshbabu wants to merge 2 commits into
Open
dipeshbabu wants to merge 2 commits into
dipeshbabu wants to merge 2 commits into
Conversation
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's npm smoke check runs TypeScript sources through the checkout launcher, allowing a broken generated bundle to pass. This change runs the generated bundle's version/help commands directly and covers Ubuntu and Windows on Node 20/22. It also makes the existing path fixtures portable and explicitly enumerates test files so Windows on Node 20 can run them.
Checks run on fix branches so each fix can be validated before PR creation.
Validation: frozen-lockfile dependencies, typecheck, full tests, npm bundle build, and generated bundle smoke checks passed on commit 40c62e8. All four platform/Node jobs passed: https://github.com/dipeshbabu/vibi-cli/actions/runs/37262194506
The application bug PRs include these CI foundation commits so their published heads match the validated commits. Merging this PR first removes those common changes from their diffs.
Closes #1.