Repository navigation
push directory filtering excludes descendants of filesystem roots - #30
Open
dipeshbabu wants to merge 3 commits into
Open
dipeshbabu wants to merge 3 commits into
dipeshbabu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory predicate appends a separator to the root. For
/or a Windows drive root, it then expects a double separator and excludes legitimate descendant sessions. Windows path case differences also cause mismatches.Use native path.relative containment checks. Tests cover filesystem roots, exact directories, nested directories, siblings, empty paths, and Windows case differences.
Validation: frozen-lockfile dependencies, typecheck, full tests, npm build, and bundled CLI version/help smoke checks. Ubuntu/Windows Node 20/22 CI passed before PR creation on this exact head commit (970f705): https://github.com/dipeshbabu/vibi-cli/actions/runs/37263329940
This branch includes the CI foundation from #2; merging that PR first removes the common CI changes from this diff.
Closes #29.