fix(app): keep idle relay links alive - #933
Merged
Merged
Conversation
Member
Author
|
@codex review @miravoss26 please review exact head |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The relay pings every 15 seconds, while Core closes a quiet connection after 45 seconds. Core refreshed its deadline only for data frames and pong frames. A relay ping therefore did not count as activity, so a healthy idle link could time out and reconnect every 45 seconds.
Impact
Idle FTW app links stay connected while relay heartbeats arrive. Missing heartbeats still cause the same timeout and reconnect path. This does not change control or safety behavior.
Regression proof
make verifypassed on exact head, including 167 optimizer tests, Go tests, vet, and buildgit range-diffis identical to the reviewed local candidateBase:
b6ee4e3bf5d144da0a226fb2b0029225cc8ada6d