feat(web): keep fleet statistics with FTW app settings - #934
Conversation
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 903e4e460a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
903e4e4 to
0db618f
Compare
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
Why
Fleet statistics belongs with the FTW app settings for normal installs, but boxes that do not use AppLink must still be able to share fleet statistics on their own.
Validation
node --test web/app-link-tab.test.mjs web/fleet-ping-tab.test.mjs— 31 passednpm test— 343 passedGOCACHE=/private/tmp/ftw-fleet-gocache-MXhf4a go test ./internal/appuplink— passedBRAND_BASE_SHA=393ecdf1c605e7baf15646133ed4ffbbbbf81198 .github/brand/check-brand-cleanup.sh— passedPLANNING_DOCS_BASE_SHA=393ecdf1c605e7baf15646133ed4ffbbbbf81198 .github/check-no-planning-docs.sh— passedmake verifyon the same Fleet patch — cleanRebase proof
The Fleet implementation commit was rebased onto post-#933
master(393ecdf1c605e7baf15646133ed4ffbbbbf81198) without changing its patch:441865cc5701b7604c38e0e8a5537029e0640be0git range-diff:903e4e46 = 0db618faweb/tree is byte-identical to reviewed head903e4e460af11a4ebb5397168b90f80cec7da1d6The second commit only fixes the two stale documentation references.
Review gate
Desktop and 390 px browser review remain required before this draft is marked ready.