Skip to content

feat(web): keep fleet statistics with FTW app settings - #934

Merged
frahlg merged 2 commits into
masterfrom
agent/fleet-statistics-with-app
Aug 17, 2026
Merged

feat(web): keep fleet statistics with FTW app settings#934
frahlg merged 2 commits into
masterfrom
agent/fleet-statistics-with-app

Conversation

@frahlg

@frahlg frahlg commented Aug 17, 2026

Copy link
Copy Markdown
Member

What changed

  • Moves the existing Fleet statistics panel onto Settings → FTW app.
  • Keeps AppLink and Fleet statistics as two separate switches.
  • Keeps Fleet statistics on by default when its config section is absent, including when AppLink is off.
  • Removes the separate Fleet ping navigation item and reuses the existing payload and privacy details.
  • Updates the two operator-facing references to the panel's new location.

Why

Fleet statistics belongs with the FTW app settings for normal installs, but boxes that do not use AppLink must still be able to share fleet statistics on their own.

Validation

  • node --test web/app-link-tab.test.mjs web/fleet-ping-tab.test.mjs — 31 passed
  • npm test — 343 passed
  • GOCACHE=/private/tmp/ftw-fleet-gocache-MXhf4a go test ./internal/appuplink — passed
  • BRAND_BASE_SHA=393ecdf1c605e7baf15646133ed4ffbbbbf81198 .github/brand/check-brand-cleanup.sh — passed
  • PLANNING_DOCS_BASE_SHA=393ecdf1c605e7baf15646133ed4ffbbbbf81198 .github/check-no-planning-docs.sh — passed
  • Earlier full make verify on the same Fleet patch — clean

Rebase proof

The Fleet implementation commit was rebased onto post-#933 master (393ecdf1c605e7baf15646133ed4ffbbbbf81198) without changing its patch:

  • stable patch ID: 441865cc5701b7604c38e0e8a5537029e0640be0
  • git range-diff: 903e4e46 = 0db618fa
  • the web/ tree is byte-identical to reviewed head 903e4e460af11a4ebb5397168b90f80cec7da1d6

The second commit only fixes the two stale documentation references.

Review gate

Desktop and 390 px browser review remain required before this draft is marked ready.

@frahlg
frahlg requested a review from miravoss26 August 17, 2026 04:42

frahlg commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head 903e4e460af11a4ebb5397168b90f80cec7da1d6. Check that Fleet statistics remains default-on when omitted, stays independent of AppLink, and that moving the existing panel onto the FTW app page does not leave a stale tab or save-hook regression.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 903e4e460a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/settings/tabs/fleet.js
@frahlg
frahlg force-pushed the agent/fleet-statistics-with-app branch from 903e4e4 to 0db618f Compare August 17, 2026 04:57

frahlg commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head 0daab46832ed14461ff3fdf2fbde9b975b4e65f0. The Fleet implementation patch is unchanged across the #933 rebase (903e4e46 = 0db618fa, stable patch ID 441865cc5701b7604c38e0e8a5537029e0640be0); the second commit only updates the two stale Settings references raised in PRRT_kwDOSArjzc6ZsT8Y. Please check the full final diff.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 0daab46832

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@frahlg
frahlg marked this pull request as ready for review August 17, 2026 05:08
@frahlg
frahlg merged commit c6b325d into master Aug 17, 2026
14 checks passed
@frahlg
frahlg deleted the agent/fleet-statistics-with-app branch August 17, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant