fix(control): keep failed command paths excluded - #922
Draft
frahlg wants to merge 2 commits into
Draft
Conversation
This was referenced Aug 16, 2026
frahlg
force-pushed
the
agent/release-command-outcome-safety
branch
from
August 16, 2026 17:12
6501114 to
820cdb7
Compare
frahlg
changed the base branch from
master
to
agent/fix-fuse-saver-live-baseline-p0
August 16, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
This closes four command-path gaps found in the stable-release audit:
ErrControlBlockednow excludes the driver even when the original refusal and a failed default recovery are joined into one error.The internal wake-cycle ID stays in Go. The driver JSON and public API do not change. Public manual driver sends keep their existing health behavior.
Failure proof
Tests fail on the old tree when:
The new barrier tests make those races deterministic. A timed-out caller releases the loadpoint tick, while the registry owner keeps the same-driver call serialized so a second command cannot overlap it.
Verification
go test -race ./internal/drivers ./internal/loadpoint ./internal/api ./cmd/ftwmake verify— 167 optimizer tests plus all Go, migration, boundary, vet, and build checksCoordination
Keep this PR in draft until file ownership is resolved:
main.goand command-outcome code. Its author must confirm this safety stack lands first, then feat(web): turn a driver's write path on from Settings #769 must rebase.This PR contains two reviewable commits: command outcome/exclusion first, then the EV/default actor boundary. The rejected intermediate mutex design is not in this branch history.