fix(control): mitigate PV-only export over limits - #888
Draft
frahlg wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxExportWceiling as the battery export guard.Safety boundary
This is partial mitigation, not a claim of hard enforcement. The current curtail contract uses
0 Was release, and Ferroamp cannot safely accept an active zero through the current path. This PR therefore sends only positive caps above the known unsafe range.PVExportResidualWreports the part of the overage that safe positive caps cannot cover, including unsupported PV. Command refusal remains visible through the existing actuation tracker. Full shutdown needs an explicit active/release contract plus per-driver zero/minimum capability and stays open in #885.Tests
Tests cover:
MaxExportWVerification:
go test -race -count=1 ./internal/controlgo test -count=1 ./cmd/ftwmake verifymake verify-all, including optimizer integration and Linux/Windows cross-buildsStack and scope
This PR is stacked on the exact reviewed head of #769 to reuse
solarSurplusWand avoid competing edits indispatch.go. Retarget it tomasterafter #769 lands.No optimizer, config or driver code changes here.
Refs #885