fix(control): preserve explicit zero battery limits - #887
Draft
frahlg wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0 Wlimit.PowerLimitscallers unchanged.0/0config-error fallback instead of disabling the whole battery.Root cause
batteries.<id>.max_charge_w: 0andmax_discharge_w: 0used pointer fields, butdriverLimitsFromcopied only values above zero. Control then read zero as “unset” and fell back toMaxCommandW(5 kW). The planner could forbid a direction while runtime still commanded it.The shared cap rule now applies to allocation, SoC clamps, post-slew clamps, charge mode, PV headroom and the fuse saver. If discharge is explicitly disabled, the fuse saver will not use that battery; another device or safety layer must handle any remaining import overage.
Tests
go test -race -count=1 ./internal/control ./cmd/ftwmake verifymake verify-all, including optimizer integration and Linux/Windows cross-buildsStack and scope
This PR is stacked on the exact reviewed head of #769 because both PRs touch
main.goanddispatch.go. Retarget it tomasterafter #769 lands.This does not change config validation or per-storage optimizer-to-dispatch assignment.
Refs #885
Related: #816