feat(profile): enforce profile policy on every execution surface (Spec 108-d) - #1411
Merged
github-actions[bot] merged 11 commits intoSep 29, 2026
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
066a20c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0813715.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://codex-108-d-profile-executio.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 36516585508 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Sep 29, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
…open (#1420) Fixes the still-actual items from the 108-a profile policy review follow-ups. - Glob compilation now uses `(?s)` so `*` matches embedded newlines in a tool identity (a deny pattern such as `github:delete*` no longer fails open on `github:delete\nrepo`). Regression cases added first and confirmed failing. - Legacy profile round-trip test now asserts byte equality (`require.Equal`), matching its doc comment. - Renamed the mislabeled "tool name containing a slash" glob case and added a real slash-containing exact case. - Corrected the node-fixture comment: only tool names and order are shared between the JSON and in-process fixtures. Not changed: items 4 and 5 are obsolete (the policy enforcement test override was removed in #1411); item 6 (REST-door test fake) is a low-value coverage gap left open. Refs #1393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforce Profiles v3 policy consistently across MCP calls and discovery,
/mcp/all, nested code execution, REST calls/replay/search, and anonymous profile scope. Denials remain typed and carryblock_reason; credential and anonymous profile switching uses one-hopswitchable_toadmission with uniform refusals.Review fixes
/mcp/p/{slug}, returning the same refusal for existing and missing profiles.Spec and findings
Spec 108-d:
specs/108-profiles-v3/(T044–T055a). Closes P3’s fail-closed enforcement gap across discovery and execution.Validation
066a20c7c8189aeaebac793ea07967a63ee70192.-race.git diff --check, formatting, build, and commit hooks passed.